GODRIVER-2432 Improve panic handling in background processes #1471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvasquez
requested review from
qingyang-hu
and removed request for
a team
API Change ReportNo changes found! |
qingyang-hu
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2432
Summary
Add a defer-recover function that logs unexpected failures encountered during topology maintenance.
Background & Motivation
Runtime fatals occurring in server maintenance methods are silently ignored. The rationale behind this is to prevent server maintenance, like updating a server, from disrupting a client's application. While there is currently no identified source for these fatals, it is presumed they may arise from the intricate locking system designed to facilitate concurrent updates. This pull request suggests the addition of a logging solution for these defer/recover blocks to learn more form clients, our unified spec test, and perhaps future telemetry.