GODRIVER-2603 - Revised error handling using Go 1.13 error APIs #1470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumarlokesh
requested review from
prestonvasquez
and removed request for
a team
prestonvasquez
requested changes
Nov 14, 2023
kumarlokesh
force-pushed
the
GODRIVER-2603
branch
from
6fc2515 to
eec27dd
Compare
API Change ReportNo changes found! |
blink1073
pushed a commit
to blink1073/mongo-go-driver
that referenced
this pull request
Nov 16, 2023
This was referenced Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2603
Summary
%wfor wrapping errorsWrappedErrorstruct for wrapping errorserrors.Isanderrors.Asfor examining wrapped errorsBackground & Motivation
As a requirement for the related ticket GODRIVER-2646, all errors are required to
be addressed to enable errorlint linter. Enabling the linter gave a significant
number of errors that would require revision.
From code review aspect, to keep the volume of changes in a single PR manageable,
I chose to address only a fraction of linter errors here. Would submit subsequent PR(s)
to fix all errors before
errorlintlinter could be enabled.