GODRIVER-2852 Use a mock connection for all CMAP spec tests. #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewdale
force-pushed
the
godriver2852-fix-pool-create-test
branch
from
38d152c to
6de4ff1
Compare
matthewdale
requested review from
prestonvasquez
and removed request for
a team
prestonvasquez
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2852
Summary
Use a mock connection for all CMAP spec tests.
Background & Motivation
Some CMAP spec tests currently use a TCP listener, but does not accept any connections or read or write data. As a result, the behavior of the tests depends on how the "zombie" TCP listener behaves, which may be inconsistent. Use a mock connection in all cases to make the tests more reliable.