always call SetStreaming if a StreamerConnection is given

Divjot Arora · Divjot Arora · commit b36e9f052afb · 2020-05-13T21:42:28.000-04:00
diff --git a/x/mongo/driver/operation.go b/x/mongo/driver/operation.go
@@ -611,11 +611,10 @@ func (op Operation) readWireMessage(ctx context.Context, conn Connection, wm []b
 		return nil, Error{Message: err.Error(), Labels: labels, Wrapped: err}
 	}
 
-	// If the server replied with moreToCome set, the connection should be marked as "streaming".
-	if wiremessage.IsMsgMoreToCome(wm) {
-		if streamer, ok := conn.(StreamerConnection); ok {
-			streamer.SetStreaming(true)
-		}
+	// If we're using a streamable connection, we set its streaming state based on the moreToCome flag in the server
+	// response.
+	if streamer, ok := conn.(StreamerConnection); ok {
+		streamer.SetStreaming(wiremessage.IsMsgMoreToCome(wm))
 	}
 
 	// decompress wiremessage

Original file line number	Diff line number	Diff line change
`@@ -611,11 +611,10 @@ func (op Operation) readWireMessage(ctx context.Context, conn Connection, wm []b`
`611`	`611`	`return nil, Error{Message: err.Error(), Labels: labels, Wrapped: err}`
`612`	`612`	`}`
`613`	`613`
`614`		`- // If the server replied with moreToCome set, the connection should be marked as "streaming".`
`615`		`- if wiremessage.IsMsgMoreToCome(wm) {`
`616`		`- if streamer, ok := conn.(StreamerConnection); ok {`
`617`		`- streamer.SetStreaming(true)`
`618`		`- }`
	`614`	`+ // If we're using a streamable connection, we set its streaming state based on the moreToCome flag in the server`
	`615`	`+ // response.`
	`616`	`+ if streamer, ok := conn.(StreamerConnection); ok {`
	`617`	`+ streamer.SetStreaming(wiremessage.IsMsgMoreToCome(wm))`
`619`	`618`	`}`
`620`	`619`
`621`	`620`	`// decompress wiremessage`