Skip to content

Commit 6e5ef26

Browse files
committed
WIP
1 parent 5118fa1 commit 6e5ef26

File tree

4 files changed

+16
-7
lines changed

4 files changed

+16
-7
lines changed

mongo/integration/unified/testrunner_operation.go

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -183,8 +183,14 @@ func executeTestRunnerOperation(ctx context.Context, operation *operation, loopD
183183
}
184184
return nil
185185
case "runOnThread":
186-
// TODO
187-
return nil
186+
operationRaw, err := args.LookupErr("operation")
187+
if err != nil {
188+
return fmt.Errorf("'operation' argument not found in runOnThread operation")
189+
}
190+
if err := operationRaw.Unmarshal(operation); err != nil {
191+
return fmt.Errorf("error unmarshalling 'operation' argument: %v", err)
192+
}
193+
return operation.execute(ctx, loopDone)
188194
case "waitForThread":
189195
// TODO
190196
return nil

x/mongo/driver/topology/pool.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -863,10 +863,12 @@ func (p *pool) interruptInUseConnections() {
863863
return
864864
}
865865

866-
if atomic.LoadInt64(&conn.state) == connConnected {
867-
conn.closeConnectContext()
868-
conn.wait() // Make sure that the connection has finished connecting.
869-
}
866+
/*
867+
if atomic.LoadInt64(&conn.state) == connConnected {
868+
conn.closeConnectContext()
869+
conn.wait() // Make sure that the connection has finished connecting.
870+
}
871+
*/
870872

871873
_ = conn.closeWithErr(poolClearedError{
872874
err: fmt.Errorf("interrupted"),

x/mongo/driver/topology/server.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -618,7 +618,7 @@ func (s *Server) update() {
618618
s.updateDescription(desc)
619619
// Retry after the first timeout before clearing the pool in case of a FAAS pause as
620620
// described in GODRIVER-2577.
621-
if err := unwrapConnectionError(desc.LastError); err != nil && timeoutCnt < 1 {
621+
if err := unwrapConnectionError(desc.LastError); err != nil && timeoutCnt < 0 {
622622
if errors.Is(err, context.Canceled) || errors.Is(err, context.DeadlineExceeded) {
623623
timeoutCnt++
624624
// We want to immediately retry on timeout error. Continue to next loop.

x/mongo/driver/topology/server_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,7 @@ func (d *timeoutDialer) DialContext(ctx context.Context, network, address string
128128

129129
// TestServerHeartbeatTimeout tests timeout retry for GODRIVER-2577.
130130
func TestServerHeartbeatTimeout(t *testing.T) {
131+
t.Skip("skipping for GODRIVER-2335")
131132
if testing.Short() {
132133
t.Skip("skipping integration test in short mode")
133134
}

0 commit comments

Comments
 (0)