fix attributeToArray method

[florianJacques]

• Fix model serialization, when model has embed relation or nested fields.

When dealing with embedded models with relationships (EmbedOne and/or EmbedMany), the serialization methods do not serialize Mongo BSON types in nested fields, as the function only converts top-level attributes.

In the exemple, prices is embedMany Relationship

 public function prices(): EmbedsMany
 {
      return $this->embedsMany(Price::class, 'prices', 'product');
 }

Before fix =>

 [
    "_id" => "667be7212ea8e4cc8b0dd636",
    "isActive" => true,
    "name" => "CREDIT_PACKAGE_3",
    "category" => "CREDIT_BALANCE",
    "quantity" => 3.0,
    "prices" => [
      [
        "currency" => "EUR",
        "price" => 5.99,
        "_id" => MongoDB\BSON\ObjectId {#4456
          +"oid": "667be7212ea8e4cc8b0dd634",
        },
      ],
    ],
]

After fix =>

 [
    "_id" => "667be7212ea8e4cc8b0dd636",
    "isActive" => true,
    "name" => "CREDIT_PACKAGE_3",
    "category" => "CREDIT_BALANCE",
    "quantity" => 3.0,
    "prices" => [
      [
        "currency" => "EUR",
        "price" => 5.99,
        "_id" => "667be7212ea8e4cc8b0dd634",
      ],
    ],
]

[GromNaN]

Thank you @florianJacques for contributing. To review your PR correctly, I need that you describe the issue, and if possible add tests validating the fix.

[florianJacques]

Thank you @florianJacques for contributing. To review your PR correctly, I need that you describe the issue, and if possible add tests validating the fix.

Test ok

[GromNaN]

The new test does not cover the issue, it works without your fix.

In order to convert date objects nested into embedded object (not embedded model), you can define a regular cast using a dot for the field path.

Example:

laravel-mongodb/tests/Models/User.php

Lines 42 to 46 in ffacc6b

	protected $casts = [
	'birthday' => 'datetime',
	'entry.date' => 'datetime',
	'member_status' => MemberStatus::class,
	];

Validated by this test:

laravel-mongodb/tests/ModelTest.php

Lines 774 to 776 in ffacc6b

	// Test with create and array property
	$user = User::create(['name' => 'Jane Doe', 'entry' => ['date' => $date]]);
	$this->assertInstanceOf(Carbon::class, $user->getAttribute('entry.date'));

[GromNaN]

This should be a private method.

[florianJacques]

Ok now is split

[florianJacques]

For the test, I simply reused existing model. Would you like me to create a new one?
Yes for nested fields (with no embed relationship), but will it work without my patch for more deep level fields?

[GromNaN]

Yes, you can create a new model class for the test.

[GromNaN]

I'm thinking of rejecting your proposal.

Embeds should not be used in this way. Instead of calling $results['addresses'], you need to call $addresses->addresses()->get() which returns a collection of Address objects by applying the castings defined in the Model.

You can also work with objects directly, in which case they are not embedded and don't automatically have an id, but you can add one.

[GromNaN]

I don't think dates should be handled here. They were not in the current code.

[florianJacques]

I understand, indeed if relationships are called, casts are automatic. Sorry for the misunderstanding.
You can reject the fix proposal. Looking forward to contributing on something else.