-
Notifications
You must be signed in to change notification settings - Fork 1.4k
PHPORM-153: Add automated release workflow #2964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actual changes LGTM but I'll defer to you and @GromNaN regarding the release template.
.github/workflows/release.yml
Outdated
|
||
TODO: one or more paragraphs describing important changes in this release | ||
|
||
A complete list of resolved issues in this release may be found in [JIRA](https://jira.mongodb.org/secure/ReleaseNote.jspa?version={1}&projectId=22488). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like something to change given the existing releases. I'm not familiar with how "Release Highlights" are generated, but we definitely don't link to JIRA. We do have a link for "Full Changelog", though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to use GitHub milestones for that.
The full git history is better for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-added automatic release note generation and removed our own release notes template. We'll customise release note generation to exclude merge-up pull requests and categorise other pull requests.
1073ebf
to
15b4c75
Compare
PHPORM-153
The release workflow is an exact copy of the one used in PHPLIB, with the necessary adjustments to the release message.
The necessary secrets have been added to the repository.