Skip to content

PHPORM-153: Add automated release workflow #2964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 23, 2024

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented May 22, 2024

PHPORM-153

The release workflow is an exact copy of the one used in PHPLIB, with the necessary adjustments to the release message.

The necessary secrets have been added to the repository.

@alcaeus alcaeus self-assigned this May 22, 2024
@alcaeus alcaeus requested a review from a team as a code owner May 22, 2024 10:10
@alcaeus alcaeus requested a review from jmikola May 22, 2024 10:10
Copy link
Member

@jmikola jmikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actual changes LGTM but I'll defer to you and @GromNaN regarding the release template.


TODO: one or more paragraphs describing important changes in this release

A complete list of resolved issues in this release may be found in [JIRA](https://jira.mongodb.org/secure/ReleaseNote.jspa?version={1}&projectId=22488).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like something to change given the existing releases. I'm not familiar with how "Release Highlights" are generated, but we definitely don't link to JIRA. We do have a link for "Full Changelog", though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to use GitHub milestones for that.
The full git history is better for now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-added automatic release note generation and removed our own release notes template. We'll customise release note generation to exclude merge-up pull requests and categorise other pull requests.

@alcaeus alcaeus force-pushed the phporm-153-automate-releases branch from 1073ebf to 15b4c75 Compare May 23, 2024 08:20
@alcaeus alcaeus requested a review from GromNaN May 23, 2024 08:20
@alcaeus alcaeus merged commit d685b6a into mongodb:4.3 May 23, 2024
25 checks passed
@alcaeus alcaeus deleted the phporm-153-automate-releases branch May 23, 2024 11:17
@GromNaN GromNaN added this to the 4.3 milestone May 31, 2024
@GromNaN GromNaN mentioned this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants