Skip to content

PHPORM-151 Update signature of Query\Builder::dump to match parent DumpableTrait #2730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2024
Merged

PHPORM-151 Update signature of Query\Builder::dump to match parent DumpableTrait #2730

merged 1 commit into from
Feb 21, 2024

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Feb 20, 2024

Fix PHPORM-151

Laravel 11 breaking change: laravel/framework@4326fc3#diff-2ed94a0ea151404a12f3c0d52ae9fb5742348578ec4a8ff79d079fa598ff145dR3878

Checklist

  • Add tests and ensure they pass (no tests)
  • Add an entry to the CHANGELOG.md file
  • Update documentation for new features (no doc)

@GromNaN GromNaN requested a review from alcaeus February 20, 2024 14:03
@GromNaN GromNaN self-assigned this Feb 20, 2024
alcaeus
alcaeus requested changes Feb 20, 2024
View reviewed changes
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request should target 5.0 if we consider this a breaking change, or 4.2 if we don't.

@GromNaN
Copy link
Member Author

GromNaN commented Feb 20, 2024

Pull request should target 5.0 if we consider this a breaking change, or 4.2 if we don't.

I added this method last week #2727, it's not released yet.

@GromNaN GromNaN requested a review from alcaeus February 21, 2024 10:20
alcaeus
alcaeus approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline. Adding dump in 4.1 is a bugfix, and it makes sense to make the signature compatible with Laravel 11 while we're adding it. LGTM!

@GromNaN GromNaN merged commit 26a6824 into mongodb:4.1 Feb 21, 2024
@GromNaN GromNaN deleted the PHPORM-151 branch February 21, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcaeus alcaeus alcaeus approved these changes

Assignees

@GromNaN GromNaN

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GromNaN @alcaeus