PHPORM-106 Implement pagination for groupBy queries #2672
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PHPORM-106
Pagination needs 2 queries:
For 1, Eloquent wraps the raw SQL into an other SQL queries. For MongoDB, we use an aggregation pipeline for groupBy queries. Getting the total count is as simple as adding a
$count
stage to the pipeline.For 2, nothing to do, the pagination leverages the query builder offset/limit methods that already works with aggregation pipeline.
I have to explicitly restrict usage of the pagination on
distinct
queries, as theCollection::distinct()
method doesn't support counting.