Test with lowest dependencies in CI #2663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
force-pushed
the
test-low-deps
branch
6 times, most recently
from
e5a4854 to
e3d3290
Compare
GromNaN
force-pushed
the
test-low-deps
branch
from
e3d3290 to
1a49980
Compare
GromNaN
commented
Nov 2, 2023
| include: | ||
| - php: '8.1' | ||
| mongodb: '5.0' | ||
| mode: 'low-deps' |
There was a problem hiding this comment.
@alcaeus this modifies an existing matrix combination instead of creating an extra one. I think it's perfect.
https://github.com/mongodb/laravel-mongodb/actions/runs/6735955088/job/18310279364?pr=2663
jmikola
approved these changes
Nov 2, 2023
| @@ -63,7 +67,7 @@ jobs: | |||
| restore-keys: ${{ matrix.os }}-composer- | |||
| - name: Install dependencies | |||
| run: | | |||
| composer install --no-interaction | |||
| composer update --no-interaction $([[ "${{ matrix.mode }}" == low-deps ]] && echo ' --prefer-lowest --prefer-stable') | |||
There was a problem hiding this comment.
This is a bit different than what we do in PHPLIB IIRC, where the CI parameter is just the args to inject (and defaults to an empty string).
I'm sure this works though so no objection. The approach in PHPLIB also doesn't change the build title, which you've achieved here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen with the recent breaking change in Laravel 10.30, we need to test for highest and lowest dependencies.