Add tests on Adding New Fields and fetch relationships withThrashed #2644

hans-thomas · 2023-10-18T15:19:11Z

Hi, I write tests for some issues to ensure they are fixed.

Error Adding New Fields #2468: Ensure it is possible to add a new field on updating an existing document
Unable to fetch relationships withThrashed #2423: Ensure it is possible to retrieve OneToMany relationship's data with and without trashed

You can close them now.

hans-thomas · 2023-10-18T15:36:44Z

I was reading issues on this repo today and answered some of them. To clean up, you can close them.

GromNaN · 2023-10-18T20:46:38Z

Thank you @hans-thomas. Your help in reviewing these old issues is much appreciated.

hans-thomas · 2023-10-21T05:58:24Z

Thank you guys. It's very nice of you❤️

hans-thomas marked this pull request as ready for review October 18, 2023 15:19

mongodb deleted a comment from codecov-commenter Oct 18, 2023

GromNaN approved these changes Oct 18, 2023

View reviewed changes

GromNaN changed the base branch from 4.1 to 4.0 October 18, 2023 20:37

hans-thomas added 4 commits October 18, 2023 22:43

Tests for new field on update;

2cbad87

Tests for HasMany relation with trashed items;

01a7b89

Update ModelTest.php

d60d00e

Fix phpcs errors;

ef42fe2

GromNaN changed the title ~~Tests for some issues~~ Add tests on Adding New Fields and fetch relationships withThrashed Oct 18, 2023

GromNaN merged commit 56a7233 into mongodb:4.0 Oct 18, 2023

GromNaN added this to the 4.0 milestone Nov 2, 2023

Provide feedback