Skip to content

Added support for "whereAll" queries #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2017
Merged

Added support for "whereAll" queries #1320

merged 1 commit into from
Oct 11, 2017

Conversation

lindelius
Copy link
Contributor

No description provided.

@lindelius lindelius changed the title Added support for a "whereAll" query Added support for "whereAll" queries Oct 5, 2017
@lindelius
Copy link
Contributor Author

Can we get this reviewed and merged, please? @jenssegers

@jenssegers jenssegers merged commit 8c17827 into mongodb:master Oct 11, 2017
@lindelius
Copy link
Contributor Author

Thanks!

@GromNaN
Copy link
Member

GromNaN commented Jul 19, 2023

Do you remember why you needed this method @lindelius?

Both

->where('tags', 'all', ['ssl', 'security'])

and

->whereAll('tags', ['ssl', 'security'])

Produced the same MongoDB query

{ tags: { $all: ["ssl", "security"] } }

@lindelius
Copy link
Contributor Author

lindelius commented Jul 21, 2023

@GromNaN Not really. I haven't used the library for years, but it was either because there was no other way to do it back then (6 years ago) or that I just wanted a nicer way to do it than to explicitly have to type the "all" parameter. Most likely the "all" option was either not documented or didn't exist. I really can't remember, though. Sorry.

@lindelius
Copy link
Contributor Author

FWIW, the projects I worked on back then are no longer using the method

@GromNaN
Copy link
Member

GromNaN commented Jul 21, 2023

Thanks for checking.

@mongodb mongodb locked as resolved and limited conversation to collaborators Jul 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants