Apply suggestions from code review

GromNaN · web-flow · commit b4da5a80f125 · 2024-07-19T10:02:19.000+02:00
diff --git a/src/Query/Builder.php b/src/Query/Builder.php
@@ -752,7 +752,7 @@ public function upsert(array $values, $uniqueBy, $update = null): int
                     $filter[$key] = $val;
                 }
 
-                if ($update === null || isset($update[$key])) {
+                if ($update === null || array_key_exists($key, $update)) {
                     $operation['$set'][$key] = $val;
                 } else {
                     $operation['$setOnInsert'][$key] = $val;
diff --git a/tests/ModelTest.php b/tests/ModelTest.php
@@ -145,7 +145,6 @@ public function testUpdate(): void
 
     public function testUpsert()
     {
-        //$user = User::upsert(['name' => 'John Doe'], ['name' => 'John Doe', 'title' => 'admin', 'age' => 35]);
 
         $result = User::upsert([
             ['email' => 'foo', 'name' => 'bar'],

Original file line number	Diff line number	Diff line change
`@@ -752,7 +752,7 @@ public function upsert(array $values, $uniqueBy, $update = null): int`
`752`	`752`	`$filter[$key] = $val;`
`753`	`753`	`}`
`754`	`754`
`755`		`- if ($update === null \|\| isset($update[$key])) {`
	`755`	`+ if ($update === null \|\| array_key_exists($key, $update)) {`
`756`	`756`	`$operation['$set'][$key] = $val;`
`757`	`757`	`} else {`
`758`	`758`	`$operation['$setOnInsert'][$key] = $val;`
Original file line number	Diff line number	Diff line change
`@@ -145,7 +145,6 @@ public function testUpdate(): void`
`145`	`145`
`146`	`146`	`public function testUpsert()`
`147`	`147`	`{`
`148`		`- //$user = User::upsert(['name' => 'John Doe'], ['name' => 'John Doe', 'title' => 'admin', 'age' => 35]);`
`149`	`148`
`150`	`149`	`$result = User::upsert([`
`151`	`150`	`['email' => 'foo', 'name' => 'bar'],`