update cmk credentials helper to make narrative more clear (#5523)

Author: jordan-smith721

source/includes/qe-tutorials/csharp/QueryableEncryptionHelpers.cs

@@ -15,10 +15,10 @@ public QueryableEncryptionHelpers(IConfigurationRoot appSettings)
         _appSettings = appSettings;
     }
 
-    public Dictionary<string, IReadOnlyDictionary<string, object>> GetKmsProviderCredentials(string kmsProvider,
+    public Dictionary<string, IReadOnlyDictionary<string, object>> GetKmsProviderCredentials(string kmsProviderName,
         bool generateNewLocalKey)
     {
-        if (kmsProvider == "aws")
+        if (kmsProviderName == "aws")
         {
             // start-aws-kms-credentials
             var kmsProviderCredentials = new Dictionary<string, IReadOnlyDictionary<string, object>>();
@@ -27,11 +27,11 @@ public Dictionary<string, IReadOnlyDictionary<string, object>> GetKmsProviderCre
                 { "accessKeyId", _appSettings["Aws:AccessKeyId"] }, // Your AWS access key ID
                 { "secretAccessKey", _appSettings["Aws:SecretAccessKey"] } // Your AWS secret access key
             };
-            kmsProviderCredentials.Add(kmsProvider, kmsOptions);
+            kmsProviderCredentials.Add("aws", kmsOptions);
             // end-aws-kms-credentials
             return kmsProviderCredentials;
         }
-        else if (kmsProvider == "azure")
+        else if (kmsProviderName == "azure")
         {
             // start-azure-kms-credentials
             var kmsProviderCredentials = new Dictionary<string, IReadOnlyDictionary<string, object>>();
@@ -41,11 +41,11 @@ public Dictionary<string, IReadOnlyDictionary<string, object>> GetKmsProviderCre
                 { "clientId", _appSettings["Azure:ClientId"] }, // Your Azure client ID
                 { "clientSecret", _appSettings["Azure:ClientSecret"] } // Your Azure client secret
             };
-            kmsProviderCredentials.Add(kmsProvider, kmsOptions);
+            kmsProviderCredentials.Add("azure", kmsOptions);
             // end-azure-kms-credentials
             return kmsProviderCredentials;
         }
-        else if (kmsProvider == "gcp")
+        else if (kmsProviderName == "gcp")
         {
             // start-gcp-kms-credentials
             var kmsProviderCredentials = new Dictionary<string, IReadOnlyDictionary<string, object>>();
@@ -54,23 +54,23 @@ public Dictionary<string, IReadOnlyDictionary<string, object>> GetKmsProviderCre
                 { "email", _appSettings["Gcp:Email"] }, // Your GCP email
                 { "privateKey", _appSettings["Gcp:PrivateKey"] } // Your GCP private key
             };
-            kmsProviderCredentials.Add(kmsProvider, kmsOptions);
+            kmsProviderCredentials.Add("gcp", kmsOptions);
             // end-gcp-kms-credentials
             return kmsProviderCredentials;
         }
-        else if (kmsProvider == "kmip")
+        else if (kmsProviderName == "kmip")
         {
             // start-kmip-kms-credentials
             var kmsProviderCredentials = new Dictionary<string, IReadOnlyDictionary<string, object>>();
             var kmsOptions = new Dictionary<string, object>
             {
                 { "endpoint", _appSettings["Kmip:KmsEndpoint"] } // Your KMIP KMS endpoint
             };
-            kmsProviderCredentials.Add(kmsProvider, kmsOptions);
+            kmsProviderCredentials.Add("kmip", kmsOptions);
             // end-kmip-kms-credentials
             return kmsProviderCredentials;
         }
-        else if (kmsProvider == "local")
+        else if (kmsProviderName == "local")
         {
             if (generateNewLocalKey)
             {
@@ -110,7 +110,7 @@ public Dictionary<string, IReadOnlyDictionary<string, object>> GetKmsProviderCre
                     { "key", localCustomerMasterKeyBytes }
                 };
 
-                kmsProviderCredentials.Add(kmsProvider, localOptions);
+                kmsProviderCredentials.Add("local", localOptions);
             }
             // end-get-local-key
             catch (Exception e)