-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(DOCSP-39165) Node and RN: Change baseURL during runtime #3243
Conversation
Readability for Commit Hash: a4bb7e3 You can see any previous Readability scores (if they exist) by looking Readability scores for changed documents:
For Grade Level, aim for 8 or below. For Reading Ease scores, aim for 60 or above:
For help improving readability, try Hemingway App. |
- Add React Native content
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits and a question about including code examples for passing in a baseURL for RN.
source/sdk/node/app-services/connect-to-app-services-backend.txt
Outdated
Show resolved
Hide resolved
source/sdk/node/app-services/connect-to-app-services-backend.txt
Outdated
Show resolved
Hide resolved
source/sdk/node/app-services/connect-to-app-services-backend.txt
Outdated
Show resolved
Hide resolved
source/sdk/node/app-services/connect-to-app-services-backend.txt
Outdated
Show resolved
Hide resolved
source/sdk/react-native/app-services/connect-to-app-services-app.txt
Outdated
Show resolved
Hide resolved
|
||
Currently, this feature is implemented as an experimental module that requires | ||
specific TypeScript configuration. The required configuration can be difficult | ||
to make work with a React Native app. Refer to :ref:`documentation for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you want to specifically reference the config file here?: https://preview-mongodbkrollinsmdb.gatsbyjs.io/realm/DOCSP-39165/sdk/node/app-services/connect-to-app-services-backend/#typescript-config-for-experimental-api
@@ -93,3 +93,32 @@ To encrypt App metadata: | |||
#. Pass the App configuration object to ``new Realm.App()``. | |||
|
|||
.. include:: /examples/generated/react-native/v12/EncryptMetadata.snippet.encrypt-metadata.tsx.rst | |||
|
|||
Connect to a Specific Server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it not possible to include a code example for passing in a baseURL? Would be nice to include an example if possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a tested code example. It doesn't work well right now with TypeScript and React Native. 😢 It's also not worth investing the time to make it work properly with our test suite.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A shame :(
Co-authored-by: lindseymoore <71525840+lindseymoore@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment, otherwise LGTM!
source/sdk/react-native/app-services/connect-to-app-services-app.txt
Outdated
Show resolved
Hide resolved
Co-authored-by: lindseymoore <71525840+lindseymoore@users.noreply.github.com>
✨ Staging URL: https://preview-mongodbmongodb.gatsbyjs.io/realm/master/ 🪵 Logs |
Pull Request Info
Jira ticket: https://jira.mongodb.org/browse/DOCSP-39165
This PR adds content to both the Node.js and React Native SDKs for changing the base URL during runtime. However, it only includes examples for the Node.js SDK. Right now, the experimental module does not really work for React Native. So, the React Native content notes that this feature exists, but is experimental and points to the Node.js content.
Sorry for the large number of changed files. I couldn't resist removing an old React Native app that we weren't using for anything.
Build errors:
label:node-change-server-during-runtime
. Manually testing shows the ref link working.Reminder Checklist
Before merging your PR, make sure to check a few things.
Release Notes
Review Guidelines
REVIEWING.md
Animal Wearing a Hat