Skip to content

DOCSP-46206: Add code guidelines page #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 22, 2025

Conversation

cbullinger
Copy link
Contributor

Pull Request Process

Please read the
Style Guide Review Process
wiki page.

Contributors should take the following actions:

  • Request a PR review in #docs-style-guide Slack channel.
  • Add the Style Guide team reps as reviewers.
  • If any reviewer requests changes, address them and request another review.
  • When you receive PR review approvals from all the Style Guide team reps,
    they will merge the PR and notify you of the merge in the Slack channel.

Pull Request Description

Add new top-level page (similar to the SEO guidelines) for general code example guidelines, including newly defined code example categories and LLM considerations.

This is the initial piece of a larger effort to formalize code-specific guidelines for our docs

JIRA URL: https://jira.mongodb.org/browse/DOCSP-46206

Staging URL: https://docs-mongodbcom-staging.corp.mongodb.com/drivers/docsworker-xlarge/NNNNN/

Copy link

netlify bot commented Apr 10, 2025

Deploy Preview for mongodb-docs-meta ready!

Name Link
🔨 Latest commit 4e3a730
🔍 Latest deploy log https://app.netlify.com/sites/mongodb-docs-meta/deploys/68079af5aa12210008929dcb
😎 Deploy Preview https://deploy-preview-187--mongodb-docs-meta.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cbullinger cbullinger force-pushed the docsp-46206-code-guidelines branch from df59662 to 0dc2a09 Compare April 14, 2025 13:33
Copy link
Collaborator

@jeff-allen-mongo jeff-allen-mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbullinger thanks for these updates! Leaving a few suggestions in the comments.

Copy link
Contributor

@stephmarie17 stephmarie17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so great to have documented, thank you! I left a few comments and had some questions.

cbullinger and others added 3 commits April 15, 2025 06:30
Co-authored-by: Jeff Allen <jeffrey.allen@10gen.com>
Co-authored-by: Stephanie <52582720+stephmarie17@users.noreply.github.com>
Co-authored-by: Jeff Allen <jeffrey.allen@10gen.com>
Co-authored-by: Stephanie <52582720+stephmarie17@users.noreply.github.com>
Copy link
Contributor

@stephmarie17 stephmarie17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a potential suggestion!

@cbullinger cbullinger merged commit 20feb9a into mongodb:master Apr 22, 2025
4 checks passed
@cbullinger cbullinger deleted the docsp-46206-code-guidelines branch April 22, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants