Skip to content

minor: bump indexmap to 2.1.0 #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

froydnj
Copy link
Contributor

@froydnj froydnj commented Dec 22, 2023

This change aligns the required indexmap version with that of serde_json so there's less crate duplication in the dependency graph.

@froydnj
Copy link
Contributor Author

froydnj commented Dec 22, 2023

(It would be nice if this was landed on the 2.8.x branch too.)

@isabelatkinson
Copy link
Contributor

Hey @froydnj, thanks for making this PR! I ran CI and the minimum supported Rust version (MSRV) compilation task failed due to indexmap 2.1.0 requiring Rust 1.64, which is higher than our current MSRV (1.61). Bumping our MSRV to 1.64 should be fine for the sake of these changes -- would you mind pushing a commit here doing so? The easiest way to make this change is to grep bson-rust for 1.61 and update to 1.64 wherever necessary.

(It would be nice if this was landed on the 2.8.x branch too.)

Per our MSRV policy we don't update the MSRV in patch versions, so we will need to wait to release this until the next minor version of this crate is published.

@froydnj
Copy link
Contributor Author

froydnj commented Jan 8, 2024

@isabelatkinson Thanks for the CI run and the additional context! I pushed a MSRV bump.

@isabelatkinson
Copy link
Contributor

Thanks for the changes @froydnj! I just pushed an update to our CI config and a fix for a clippy failure that came with the MSRV bump. I'm going to tag in another team member for review and then this should be ready to merge.

@isabelatkinson isabelatkinson requested a review from abr-egn January 9, 2024 17:37
Copy link
Contributor

@abr-egn abr-egn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@isabelatkinson isabelatkinson merged commit d044889 into mongodb:main Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants