[DNM] chore(467) rename NodeOptions to MongoClientOptions #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Dec 1, 2020
|
TODO: merge after |
addaleax
added a commit
that referenced
this pull request
Jun 16, 2021
Also includes the change from #219 and bumps mongodb-connection-model to a version that depends on the 3.x driver directly instead of using it as a peer dependency, and minor drive-by things I’ve noticed (use `mongodb` itself only for typed imports, use `assert.strictEqual` where it gives a better error message, adjust types in preparation for a 4.0 driver update).
10 tasks
addaleax
added a commit
that referenced
this pull request
Jun 21, 2021
Also includes the change from #219 and bumps mongodb-connection-model & mongodb-data-service to versions that depend on the 4.x driver as a peer dependency, and minor drive-by things I’ve noticed (use `mongodb` itself only for typed imports, use `assert.strictEqual` where it gives a better error message, adjust types in some places). This also includes a hack that was necessitated by the fact that we’re using a prerelease of the driver package. We should be able to remove that once 4.0.0 is released.
|
Merged in #301 🎆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MONGOSH-467 Upgrade the Node driver to 4.0
Description
Previously we were making our own options interface
NodeOptionsbut now that the driver is in typescript we can use theirMongoClientOptionsinterface directly. This will need to be merged after the shell is released with the change