fix: wrap the bus for hookLogger

Wrapping the bus can allow us to inject onBus onto the logger which can help us prevent logs being created from there. That said, we still have the problem of having to either re-register those hooks each time, so we may want to instead update hookLogger to take function for getting the latest log rather than just a variable.

Author: gagik

packages/logging/src/helpers.ts

@@ -1,3 +1,6 @@
+import type { MongoshBus, MongoshBusEventsMap } from '@mongosh/types';
+import { once } from 'events';
+
 /**
  * A helper class for keeping track of how often specific events occurred.
  */
@@ -47,3 +50,10 @@ export function toSnakeCase(str: string): string {
 
   return matches.map((x) => x.toLowerCase()).join('_');
 }
+
+export async function waitBus<K extends keyof MongoshBusEventsMap>(
+  bus: MongoshBus,
+  event: K
+): Promise<void> {
+  await once(bus, event);
+}

packages/logging/src/logging-and-telemetry.spec.ts

@@ -221,6 +221,29 @@ describe('MongoshLoggingAndTelemetry', function () {
     expect(analyticsOutput).to.have.lengthOf(1);
   });
 
+  it('detaching logger applies to devtools-connect cases', function () {
+    loggingAndTelemetry.setup();
+    loggingAndTelemetry.attachLogger(logger);
+
+    bus.emit('devtools-connect:connect-fail-early');
+    bus.emit('devtools-connect:connect-fail-early');
+
+    expect(logOutput).to.have.lengthOf(2);
+    // No analytics event attached to this
+    expect(analyticsOutput).to.have.lengthOf(0);
+
+    loggingAndTelemetry.detachLogger();
+    bus.emit('devtools-connect:connect-fail-early');
+
+    expect(logOutput).to.have.lengthOf(2);
+    expect(analyticsOutput).to.have.lengthOf(0);
+
+    loggingAndTelemetry.attachLogger(logger);
+
+    bus.emit('devtools-connect:connect-fail-early');
+    expect(logOutput).to.have.lengthOf(3);
+  });
+
   it('detaching logger mid-way leads to no logging but persists analytics', function () {
     loggingAndTelemetry.setup();
     loggingAndTelemetry.attachLogger(logger);