WIP feat!(mongodb-log-writer): add ability to disable logging MONGOSH-1988 #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new isDisabled field to disable the writing of logs. This can be modified using the new enable() and disable() methods.
…instead of parameters This is a breaking change which I believe would be useful for the future to create better consistency between LogManager and LogWriter and scale better as we add more parameters to log writer settings.
gagik
changed the title
gagik
force-pushed
the
gagik/add-disable
branch
from
ac54f39 to
5f383d0
Compare
gagik
changed the title
|
The point of using something like |
|
@addaleax This is about to get revamped as I didn't originally follow the tech design, thus I put it into draft again |
|
Closing as there are no changes needed in the log writer package itself for the purposes of mongodb-js/mongosh#2325 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP - do not review
Adds a new
isDisabledfield to disable the writing of logs. This can be modified using the newenable()anddisable()methods.See: mongodb-js/mongosh#2325