Skip to content
This repository was archived by the owner on May 17, 2021. It is now read-only.

Commit c76037c

Browse files
authored
feat: do not re-run on other tabs changes COMPASS-4154 (#328)
* feat: do not re-run on other tabs changes COMPASS-4154 * fix: set isEditable after query succeeds * remove debug * chore: clean dependencies * mongodb-query-parser * add task to test inside compass * clone compass under tmp * Align maxtimems default with query bar and optimize count * allow 'fetching' state without breaking table view * add outdated warning
1 parent 125b0a1 commit c76037c

File tree

17 files changed

+2015
-1756
lines changed

17 files changed

+2015
-1756
lines changed

.depcheckrc

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
ignores: [
2+
"font-awesome",
3+
"stores",
4+
"actions",
5+
"components",
6+
"plugin",
7+
"pre-commit",
8+
"moment",
9+
"babel-*",
10+
"karma-*",
11+
"webpack-*"
12+
]

.eslintignore

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
node_modules/**
2+
lib/**
3+
coverage/**
4+
.nyc_output/**
5+
src/assets/**
6+
compass/**

.github/workflows/run-tests.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
strategy:
1414
matrix:
1515
mongoVersion: [stable, unstable]
16-
16+
1717
env:
1818
MONGODB_VERSION: ${{ matrix.mongoVersion }}
1919
MONGODB_TOPOLOGY: standalone
@@ -35,16 +35,17 @@ jobs:
3535
${{ runner.os }}-build-${{ env.cache-name }}-
3636
${{ runner.os }}-build-
3737
${{ runner.os }}-
38-
38+
3939
- name: Install Required OS Packages
4040
run: sudo apt-get -y install libkrb5-dev libsecret-1-dev net-tools
41-
41+
4242
- name: Install NPM Packages
4343
run: npm install
44-
44+
4545
- name: Check and Test
4646
run: |
4747
npm run check
48+
npm run compile
4849
npm run test
4950
while true; do \
5051
MATCH="$(sudo netstat -tlnp | grep 27018 || true)"; \

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,3 +11,4 @@ coverage
1111
.nyc_output
1212
*.swp
1313
src/assets/fonts/akzid*
14+
compass/

.npmignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ src/
99
mocha-webpack.opts
1010
scripts/
1111
test/
12-
.storybook/
1312
coverage/
1413
.nyc_output/
1514
.github/

.storybook/config.js

Lines changed: 0 additions & 14 deletions
This file was deleted.

.storybook/webpack.config.js

Lines changed: 0 additions & 21 deletions
This file was deleted.

config/project.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,6 @@ module.exports = {
1818
// The path to the electron directory
1919
electron: path.join(__dirname, '/../electron'),
2020

21-
// The path to the storybook directory
22-
storybook: path.join(__dirname, '/../.storybook'),
23-
2421
// The path to the test directory.
2522
test: path.join(__dirname, '/../test')
2623
},

config/webpack.base.config.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ module.exports = {
1717
modules: path.join(project.path.src, 'modules'),
1818
plugin: path.join(project.path.src, 'index.js'),
1919
stores: path.join(project.path.src, 'stores'),
20-
storybook: project.path.storybook,
2120
'react-dom': '@hot-loader/react-dom'
2221
}
2322
},

electron/renderer/stores/query-changed-store.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@ const EXTENDED_QUERY_PROPERTIES = QUERY_PROPERTIES.concat([
1010
'queryState',
1111
'ns'
1212
]);
13+
14+
const DEFAULT_INITIAL_MAX_TIME_MS = 60000;
15+
1316
/**
1417
* This is a convenience store that only triggers when the actual query
1518
* object (stored as `QueryStore.lastExecutedQuery`) has changed, e.g.
@@ -79,7 +82,7 @@ const QueryChangedStore = Reflux.createStore({
7982
sample: false,
8083

8184
// internal query properties
82-
maxTimeMS: 5000,
85+
maxTimeMS: DEFAULT_INITIAL_MAX_TIME_MS,
8386

8487
// string values for the query bar input fields
8588
filterString: '',

0 commit comments

Comments
 (0)