Remove color escape after newline from diff line #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richerve
reviewed
Nov 22, 2021
| addFormat = "\x1b[32m+%s" // Foreground Green | ||
| removeFormat = "\x1b[31m-%s" // Foreground Red | ||
| equalFormat = "\x1b[0m %s" // No Color | ||
| addFormat = "\x1b[32m+%s\x1b[0m" // Foreground Green |
There was a problem hiding this comment.
Yes it removes the color code. Since this is a line level diff we should be able to add and remove the color code for each write and have a line level color code. We need to remove it to cover the case where the diff hits EOF and no additional context lines would be written. In that case, we don't want to leave the foreground color in the + or - color or the next addition to that text buffer/string will also be in that color.
richerve
approved these changes
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This returns the output color to neutal after writing a format line and removes the need for an equalFormat color code.