[LINK-2174] add support for authnMethod config #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mt-rsobachi
reviewed
Nov 16, 2022
mt-max
requested changes
Nov 16, 2022
mt-max
requested changes
Nov 16, 2022
mt-max
reviewed
Nov 16, 2022
mt-max
previously approved these changes
Nov 17, 2022
mt-max
previously approved these changes
Nov 17, 2022
mt-rsobachi
reviewed
Nov 18, 2022
mt-rsobachi
previously approved these changes
Nov 18, 2022
awe-mt
reviewed
Nov 18, 2022
There was a problem hiding this comment.
A couple of questions.
- What is samlSubjectId? Is that required for SSO?
- How much complexity does it add for you to support preferredAuthenticationMethod being an array? I think, as it is currently implemented, it does not make sense for it to be an array. I'd like to argue for changing that before we release it to our clients.
mt-rsobachi
previously approved these changes
Nov 21, 2022
mt-rsobachi
reviewed
Nov 21, 2022
Co-authored-by: Roberto Sobachi <112455597+mt-rsobachi@users.noreply.github.com>
mt-rsobachi
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.