Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monero-wallet-rpc: Add sub-address parameters to make_integrated_address API #3679

Closed
mmorrell opened this issue Apr 21, 2018 · 4 comments
Closed

Comments

@mmorrell
Copy link

mmorrell commented Apr 21, 2018

Currently, the "make_integrated_address" API in monero-wallet-rpc only generates an integrated address for the main account (at address_index 0).

There should be a version of "make_integrated_address" which can work on sub-addresses. Such as make_integrated_address(address_index) and/or make_integrated_address(address).

This could be done adding by optional parameters to the existing make_integrated_address API.

e.g.

{
	"jsonrpc":"2.0","id":"0",
	"method":"make_integrated_address",
	"params": {
		"address_index": 3
	}
}

Use case: User wants to track individual payments to each subaddress.

@mmorrell mmorrell changed the title monero-wallet-rpc: Add sub-address version of make_integrated_address API monero-wallet-rpc: Add sub-address parameters to make_integrated_address API Apr 21, 2018
@moneroexamples
Copy link
Contributor

You mean making integrated sub-addresses? If so, this has been discussed already and the idea of integrated sub-addresses has been dropped.

#2056 (comment)

@krtschmr
Copy link

subadresses don't have payment IDs, or am i wrong?

@moneromooo-monero
Copy link
Collaborator

Subaddresses are supposed to obsolete payment ids.

@mmorrell
Copy link
Author

mmorrell commented Apr 22, 2018

Fair enough. Thanks for looking into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants