Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak #79

Closed
gjohnson opened this issue May 5, 2014 · 6 comments
Closed

Memory leak #79

gjohnson opened this issue May 5, 2014 · 6 comments

Comments

@gjohnson
Copy link

gjohnson commented May 5, 2014

I am still tracking this down, but I am pretty sure the memoize stuff added in 803d2e2 introduced memory leaking. If you need to format a million unique dates, it's basically going to cache all of them and never let go.

@gjohnson
Copy link
Author

gjohnson commented May 5, 2014

Related: #44

@aheckmann
Copy link

it's a pretty bad memory leak and caused us to stop using this module for now.

@alexgorbatchev
Copy link

Curious if there's an update on this?

@timrwood
Copy link
Member

See #82.

I'm working on using a new precomputed data format which should solve this issue.

@gjohnson
Copy link
Author

Thanks for the update! Will put comments on that PR.

@timrwood
Copy link
Member

This is fixed in the rewrite and will go out in the 0.1.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants