You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
all modules must share the same Typescript version
The first issue may just be a nuisance, requiring more maintenance work.
The second one though may be more severe, in the worst case requiring us to drop old modules or to wait until all modules are able to use new TS versions.
In #864 we already moved to running each benchmark in its own process. Might be just the next logical step to also isolate node_modules? That also helps isolating the different build / code generation steps required for some modules.
Yes, 100% the issue is there and needs to be fixed.
I wanted to re-design the entire project setup entirely, including this problem if isolation and the umbrella issue is #899, albeit it does not have the meat on that bone there, regarding the details.
I will link to this issue from there for documentation.
Having all tested modules share the same node_modules namespace seems to introduce new issues / limits:
The first issue may just be a nuisance, requiring more maintenance work.
The second one though may be more severe, in the worst case requiring us to drop old modules or to wait until all modules are able to use new TS versions.
In #864 we already moved to running each benchmark in its own process. Might be just the next logical step to also isolate node_modules? That also helps isolating the different build / code generation steps required for some modules.
@moltar any feedback?
The text was updated successfully, but these errors were encountered: