Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ahead-of-time clarification #1217

Open
MentalGear opened this issue Feb 20, 2024 · 3 comments
Open

ahead-of-time clarification #1217

MentalGear opened this issue Feb 20, 2024 · 3 comments

Comments

@MentalGear
Copy link

MentalGear commented Feb 20, 2024

first off: Thanks your for this objective and comprehensive benchmark! It's really annoying that every library uses their own benchmarks and not a neutral one like yours.

I was wondering if Typebox "ahead-of-time" designation is the same as using the compiled schema plus imported as a module; does the Just-in-Time version also use the compiled schema?

@MentalGear
Copy link
Author

OK, I checked the code and the compiled schema is always used.

import { TypeCompiler } from '@sinclair/typebox/compiler';

Still, maybe it could be added that the compiled schema is used just to be clearer.

@moltar
Copy link
Owner

moltar commented Feb 20, 2024

@MentalGear Thank you for your kind words.

It's really annoying that every library uses their own benchmarks and not a neutral one like yours.

Agreed, that was the intended goal.

However, I think we are still not achieving this nirvana 😁

Please let me know if you have any thoughts on this in #300 and #1126.

I was wondering if Typebox "ahead-of-time" designation is the same as using the compiled schema plus imported as a module; does the Just-in-Time version also use the compiled schema?

The context for this is in #1125

@MentalGear
Copy link
Author

MentalGear commented Feb 20, 2024

However, I think we are still not achieving this nirvana 😁

I guess for that, one would need to collect all lib's benchmarks and have them run against all libs as well. :D

Please let me know if you have any thoughts on this in #300 and #1126.

Yes, coherent and clear labels (with an icon hover) would be great. I also assume (dynamic) means a not compiled Schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants