Allow frames to send after the arrival of the RST_STREAM. #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent exceptions for the common case in which the serving endpoint sends frames after the RST_STREAM has been sent from the client endpoint. Often frames are enqueued prior to the arrival of the RST_STREAM, but sent after. This should be expected based on HTTP/2 spec, section 6.4. https://http2.github.io/http2-spec/#rfc.section.6.4 "However, after sending the RST_STREAM, the sending endpoint MUST be prepared to receive and process additional frames sent on the stream that might have been sent by the peer prior to the arrival of the RST_STREAM."
|
Can confirm it's working for me too. Thanks! |
|
@nwgh http2 is unusably crashy, this PR fixes that. When will it be merged? |
|
When will it be merged? |
|
This should be merged. It's been months. |
akc42
added a commit
to akc42/node-http2
that referenced
this pull request
May 27, 2017
|
works for me too, thanks - i can push multiple resources now.. |
This was referenced Aug 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent exceptions for the common case in which the serving endpoint sends frames
after the RST_STREAM has been sent from the client endpoint. Often frames are
enqueued prior to the arrival of the RST_STREAM, but sent after. This should be
expected based on HTTP/2 spec, section 6.4.
https://http2.github.io/http2-spec/#rfc.section.6.4
"However, after sending the RST_STREAM, the sending endpoint MUST be prepared to
receive and process additional frames sent on the stream that might have been
sent by the peer prior to the arrival of the RST_STREAM."