Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move example app into separate repo or subdirectory #24

Closed
darinwilson opened this issue Sep 19, 2016 · 1 comment
Closed

Move example app into separate repo or subdirectory #24

darinwilson opened this issue Sep 19, 2016 · 1 comment

Comments

@darinwilson
Copy link
Contributor

I'd like to propose switching torch from being structured as an umbrella app, to either having the example app in a separate repo, or pushing it down into a separate subdirectory (like we're doing with thesis-phoenix.

The biggest bummer about the current arrangement is that it's impossible to set up the torch dependency to point to your own git branch because the dependency format in mix.exs does not support pointing to a subdirectory (AFAIK). This means you can only use the current official hex package, or a repo on your local filesystem. Pointing your deps at github branches is not ideal, but it's a necessary evil, particularly in these early stages.

I'm open to other possibilities, but the current setup is a little clumsy when developing new features.

@darinwilson
Copy link
Contributor Author

Closed by #33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant