Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix includeParent field value not matching Parameter#defaultValue #1104

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Fix includeParent field value not matching Parameter#defaultValue #1104

merged 1 commit into from
Jul 2, 2024

Conversation

Marcono1234
Copy link
Contributor

The field value is overwritten by Parameter#defaultValue anyway, but the mismatching initial field value might lead to confusion nonetheless.

Looks like this was an oversight when #817 changed the defaultValue.

The field value is overwritten by `Parameter#defaultValue` anyway, but the
mismatching initial field value might lead to confusion nonetheless.
@slawekjaranowski slawekjaranowski added this to the next-release milestone Jul 1, 2024
@slawekjaranowski slawekjaranowski self-assigned this Jul 1, 2024
@slawekjaranowski slawekjaranowski merged commit 13242ee into mojohaus:master Jul 2, 2024
26 checks passed
@Marcono1234 Marcono1234 deleted the defaultValue-mismatch branch July 7, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants