Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencyExcludes/dependencyIncludes should filter on the output dependency versions #921

Closed
andrzejj0 opened this issue Feb 21, 2023 · 3 comments

Comments

@andrzejj0
Copy link
Contributor

It looks like the options filter on the input dependencies, i.e. dependencies that are already present in the POM. I think they should actually filter on output dependencies (regarding versions).

Question is whether this change should be applied directly or using a new feature toggle (to avoid backwards incompatibilities). Although I expect the current behaviour is not intuitive and direct change would not bring about much harm.

@andrzejj0
Copy link
Contributor Author

@andrzejj0 andrzejj0 closed this as not planned Won't fix, can't repro, duplicate, stale Feb 21, 2023
@andrzejj0 andrzejj0 reopened this Feb 22, 2023
@andrzejj0
Copy link
Contributor Author

andrzejj0 commented Feb 22, 2023

Tentatively reopening: the semantics of the feature is unclear and even misleading to most users and it would make much more sense to treat version (and, by extension, the whole filter) as that of the target dependency.

To be decided where to go from here:

  • if we changed the meaning of this so that it targets target dependencies, it would pretty much duplicate ruleSet and make ignoredVersions obsolete (which is just a means of providing ruleSet via parameters).

@slawekjaranowski any thoughts?

Or maybe: make the documentation more clean on it and provide examples how to use it, and how to use the ignoredVersions feature to achieve the goal of filtering on target dependencies?

andrzejj0 added a commit to andrzejj0/versions-maven-plugin that referenced this issue May 15, 2023
…udes/dependencyExcludes with a faq section and an example
@andrzejj0
Copy link
Contributor Author

Made a PR with some documentation changes.

andrzejj0 added a commit to andrzejj0/versions-maven-plugin that referenced this issue May 15, 2023
…udes/dependencyExcludes with a faq section and an example
andrzejj0 added a commit to andrzejj0/versions-maven-plugin that referenced this issue May 15, 2023
…udes/dependencyExcludes with a faq section and an example
andrzejj0 added a commit to andrzejj0/versions-maven-plugin that referenced this issue May 15, 2023
…udes/dependencyExcludes with a faq section and an example
slawekjaranowski pushed a commit that referenced this issue May 15, 2023
…endencyExcludes with a faq section and an example
andrzejj0 added a commit to andrzejj0/versions-maven-plugin that referenced this issue May 19, 2023
andrzejj0 added a commit to andrzejj0/versions-maven-plugin that referenced this issue May 19, 2023
andrzejj0 added a commit to andrzejj0/versions-maven-plugin that referenced this issue May 19, 2023
andrzejj0 added a commit to andrzejj0/versions-maven-plugin that referenced this issue May 19, 2023
andrzejj0 added a commit to andrzejj0/versions-maven-plugin that referenced this issue May 20, 2023
andrzejj0 added a commit to andrzejj0/versions-maven-plugin that referenced this issue May 20, 2023
andrzejj0 added a commit to andrzejj0/versions-maven-plugin that referenced this issue May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant