Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class-level caches are not restricted, will leak memory with mvnd #892

Closed
andrzejj0 opened this issue Jan 2, 2023 · 3 comments · Fixed by #893
Closed

Class-level caches are not restricted, will leak memory with mvnd #892

andrzejj0 opened this issue Jan 2, 2023 · 3 comments · Fixed by #893
Milestone

Comments

@andrzejj0
Copy link
Contributor

andrzejj0 commented Jan 2, 2023

Maven daemon (mvnd) keeps loaded plugin classes in memory. This means that caches that we have will only grow with time with such setup.

This ultimately leads to JVMs running out of allocated memory, pods getting recreated, etc., but this should probably be controlled and restricted.

Todo: Introduce a limit to those caches.

@slawekjaranowski
Copy link
Member

@ajarmoniuk By the way we don't need special issue, when we provide PR at the same time.

@andrzejj0
Copy link
Contributor Author

Ok. Still, I think this should be dealt with in maven-core too (together with the caching). I'm also creating a PR to get rid of the ComparableVersion duplicate in m-v-p.

@TobiX
Copy link
Contributor

TobiX commented Jan 4, 2023

@ajarmoniuk Thanks. I was hesitant to introduce a new dependency for a size-restricted cache, so my first implementation was unbound.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants