Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depManagement from parent should be used with processDependencyManagementTransitive=false #1004

Open
slawekjaranowski opened this issue Sep 11, 2023 · 2 comments

Comments

@slawekjaranowski
Copy link
Member

When we set processDependencyManagementTransitive=false dependencyManagement from parent should be still used.

eg. We have a IT - it-dependency-updates-aggregate-report-issue-333 which will fail with processDependencyManagementTransitive=false

According to documentation:

Whether to process the dependencyManagement part transitive or not. 
In case of <type>pom</type>and <scope>import</scope> ...

I understood that only items imported by pom are skipped ... not everything from parent pom.

First we need agree what this options means and next check if implementation meet requirements.

@andrzejj0
Copy link
Contributor

The documentation is wrong.

If I didn't take the documentation of the parameter into account, it would look OK to me:

The dependencyManagement item missing from the aggregate report with processDependencyManagementTransitive=false is dummy-lib:2.0.0, which is a transitive dependencyManagement item from the parent of pom.xml -- see

When debugging, I see that the functional difference is that with processDependencyManagementTransitive=false, we're taking dependency management items from the original model whereas with the parameter set to true, from the interpolated model. The latter will contain all transitive dependencies, not just with scope pom or import.

I don't see any reflection of the original documentation in the plugin code. I suggest that we change the docs to read that the option disables reporting on transitive dependency management, ie taken from parent or dependencies with scope import.

Copy link

This issue is stale because it has been open 365 days with no activity. Remove stale label or comment or this will be closed in 30 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants