Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize hard-coded 'switch' ID and harmonize with hub name in all ML services #3984

Closed
61 tasks done
oderayi opened this issue Jun 26, 2024 · 0 comments · May be fixed by mojaloop/helm#640
Closed
61 tasks done

Parameterize hard-coded 'switch' ID and harmonize with hub name in all ML services #3984

oderayi opened this issue Jun 26, 2024 · 0 comments · May be fixed by mojaloop/helm#640

Comments

@oderayi
Copy link

oderayi commented Jun 26, 2024

Goal:

As an adopter of Mojaloop building interconnected Mojaloop schemes using proxy

I would like to be able to configure unique names for each Mojaloop Scheme

so that messages can be routed correctly across the schemes and each of the participants can validate JWS error messages from either scheme

Acceptance Criteria:

  • Verify that a mojaloop can be configured to have a different identity to ‘switch'
  • Verify that the configured name is used in FSPIOP-Source or FSPIOP-Destination headers where applicable
  • Verify that usage of the ‘switch’ name in all services through central-services-shared enums (ENUM.Headers.FSPIOP.SWITCH , ENUM.Http.HeaderResources.SWITCH) and functions (transformHeaders, initializeCache kafka.proceed) are removed or parameterized
  • Verify that the configured name is used in JWS signing where applicable
  • Verify that the GP test pass with the hub's identifier not being the default (I.e. not 'switch') using a helm Kubernetes deployment. (OSS)
  • The following need to be checked:
    • ALS - fx branch
    • quoting Service - fx branch
    • Central Ledger - FX branch
    • Central Services Shared - main
    • Central Services Stream - main
    • ML API Adapter - fx branch
    • SDK standard components - main
    • SDK Scheme Adapter - main
    • ML core test harness - fx branch
    • Bulk API adapter - main
    • Central Settlement - fx branch
    • Thirdparty API svc - main
    • Transaction Request Service - main
    • Auth Service - main
    • Simulator - main
    • Helm chart - fx branch

Complexity: <High|Medium|Low> > A short comment to remind the reason for the rating

Uncertainty: <High|Medium|Low> > A short comment to remind the reason for the rating


Tasks:

  • Implement in ALS - fx branch
  • Implement in Quoting Service - fx branch
  • Implement in Central Ledger - fx branch
  • Implement in Central Services Shared - main
  • Implement in Central Services Stream - main
  • Implement in ML API Adapter - fx branch
  • Implement in SDK standard components - main
  • Implement in SDK Scheme Adapter - main
  • Implement in ML core test harness - fx branch
  • Implement in Bulk API adapter - main
  • Implement in Central Settlement - fx branch
  • Implement in Third-party API svc - main
  • Implement in Transaction Request Service - main
  • Implement in Auth Service - main branch
  • Implement in Simulator - main
  • Implement in Helm chart - fx branch
  • Implement in ML core test harness - fx branch

Done

  • Acceptance Criteria pass
  • Designs are up-to date
  • Unit Tests pass
  • Integration Tests pass
  • Code Style & Coverage meets standards
  • Changes made to config (default.json) are broadcast to team and follow-up tasks added to update helm charts and other deployment config.
  • TBD

Pull Requests:

Follow-up:

  • N/A

Dependencies:

  • N/A

Accountability:

  • Owner: TBC
  • QA/Review: TBC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant