Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[helm][testing-toolkit-test-cases] Fix delay based tests and quoting service /health tests #3949

Open
kleyow opened this issue Jun 14, 2024 · 2 comments
Labels
bug Something isn't working or it has wrong behavior on a Mojaloop Core service core-dev-squad oss-ttk Related to the Mojaloop testing toolkit to-be-refined This story is ready to be groomed

Comments

@kleyow
Copy link

kleyow commented Jun 14, 2024

Summary:
Currently the GP tests fail due to older versions of the ttk and ttk test cases

golden_path/feature_tests/Active_Inactive_participants/active_and_inactive_participants_accounts.json - Due to faulty delay code that has been fixed in ml-testing-toolkit v17.2.1

golden_path/quoting_service/quoting_service.json - Due to health endpoint with datastore information being moved to the quoting handler.

The ttk test cases need a new versioned release and the helm charts be updated with a minor release to v16.0.1 to fix these GP tests.

Tasks:
[ ] Update helm mojaloop chart to v16.0.1
[ ] Update helm ttk versions to v17.2.1 and subsequent chart version
[ ] Update helm testing-toolkit-test-cases to v16.0.1 and subsequent chart version

Severity:
(Low, Medium, High)

Priority:
(Critical, Medium, Low)

Expected Behavior
These GP tests pass

Steps to Reproduce

  1. Deploy v16.0.0 on IAC
  2. Run GP

Specifications

  • Component (if known): Mojaloop charts v16
  • Version:
  • Platform: IAC
  • Subsystem:
  • Type of testing:
  • Bug found/raised by:

Notes:

  • Severity when opened:
  • Priority when opened:

image.png

@kleyow kleyow added bug Something isn't working or it has wrong behavior on a Mojaloop Core service oss-ttk Related to the Mojaloop testing toolkit to-be-refined This story is ready to be groomed labels Jun 14, 2024
@elnyry-sam-k
Copy link
Member

hi @kleyow , thanks for catching this.

This should've been done while updating the structure of the quoting service, you're correct!

But in this comment:

golden_path/feature_tests/Active_Inactive_participants/active_and_inactive_participants_accounts.json - Due to faulty delay code that has been fixed in v17.2.1

which service / repo version are you referring to, as v17.2.1?

@elnyry-sam-k elnyry-sam-k changed the title [helm][ml-testing-toolkit][testing-toolkit-test-cases] Fix delay based tests and quoting service /health tests [helm][testing-toolkit-test-cases] Fix delay based tests and quoting service /health tests Jun 14, 2024
@kleyow
Copy link
Author

kleyow commented Jun 14, 2024

@elnyry-sam-k ml-testing-toolkit v17.2.1, updated the opening post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working or it has wrong behavior on a Mojaloop Core service core-dev-squad oss-ttk Related to the Mojaloop testing toolkit to-be-refined This story is ready to be groomed
Projects
None yet
Development

No branches or pull requests

2 participants