Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Participant data to be invalidated when details change #3775

Open
kleyow opened this issue Mar 6, 2024 · 1 comment
Open

Participant data to be invalidated when details change #3775

kleyow opened this issue Mar 6, 2024 · 1 comment
Labels
bug Something isn't working or it has wrong behavior on a Mojaloop Core service to-be-refined This story is ready to be groomed

Comments

@kleyow
Copy link

kleyow commented Mar 6, 2024

Summary:
[quoting-service][account-lookup-service] Cache implementation of participants and GP test collection don't work together when activating and deactivating participants in tests while cache values are high in these services.

Affected tests

  • Active and inactive participant - testing-toolkit-test-cases/collections/hub/golden_path/feature_tests/Active_Inactive_participants/active_and_inactive_participant.json
  • Active and inactive participant account - testing-toolkit-test-cases/collections/hub/golden_path/feature_tests/Active_Inactive_participants/active_and_inactive_participants_accounts.json
  • RESERVE NOTIFICATION POSITIVE - TESTFSP1 TESTFSP2 - testing-toolkit-test-cases/collections/hub/golden_path/feature_tests/post_scenarios/reserve_notification_positive_testfsp1_testfsp2.json

There needs to be some way to invalidate caches in the quoting service and account lookup services after GP tests deactivate a participant so that the services are not working off of stale state in GP tests.

The known issue can be resolved by setting cache expiry very low in lieu of fix

  • PARTICIPANT_DATA_EXPIRES_IN_MS in the quoting service
  • CENTRAL_SHARED_PARTICIPANT_CACHE_CONFIG.expiresIn in ALS

Severity:
(Low, Medium, High)

Priority:
(Critical, Medium, Low)

Expected Behavior

Steps to Reproduce
1.
2.
3.

Specifications

  • Component (if known):
  • Version:
  • Platform:
  • Subsystem:
  • Type of testing:
  • Bug found/raised by:

Notes:

  • Severity when opened:
  • Priority when opened:
@kleyow kleyow added bug Something isn't working or it has wrong behavior on a Mojaloop Core service to-be-refined This story is ready to be groomed labels Mar 6, 2024
@elnyry-sam-k
Copy link
Member

elnyry-sam-k commented Mar 6, 2024

Very good find @kleyow ..

There was a discussion around this a while ago - "to invalidate cache" when changes to participants happen, but as this brought about, it wasn't implemented then.

As you rightly said, low expiry times help alleviate the issue but do not fix it directly.

Thanks again!

@elnyry-sam-k elnyry-sam-k changed the title [quoting-service][account-lookup-service] Cache implementation of participants and GP test collection don't work together when activiating and deactivating participants in tests while cache values are high in these services. Cache implementation of participants needs cache invalidation when participants status/details change Mar 6, 2024
@elnyry-sam-k elnyry-sam-k changed the title Cache implementation of participants needs cache invalidation when participants status/details change Cache for participant data needs invalidation when participants status/details change Mar 6, 2024
@elnyry-sam-k elnyry-sam-k changed the title Cache for participant data needs invalidation when participants status/details change Participant data to be invalidated when details change Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working or it has wrong behavior on a Mojaloop Core service to-be-refined This story is ready to be groomed
Projects
None yet
Development

No branches or pull requests

2 participants