Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALS node optimization: Avoid Returning Resolved Promises #3620

Open
15 tasks
vijayg10 opened this issue Nov 6, 2023 · 0 comments
Open
15 tasks

ALS node optimization: Avoid Returning Resolved Promises #3620

vijayg10 opened this issue Nov 6, 2023 · 0 comments

Comments

@vijayg10
Copy link

vijayg10 commented Nov 6, 2023

Goal:

As a <stakeholder|persona>

I want to refactor return statements to return unresolved promises instead of awaiting them

so that our asynchronous operations become more efficient, reducing unnecessary overhead and improving overall application performance.

Acceptance Criteria:

  • Refactor return statements within functions to return unresolved promises directly, eliminating the use of await
  • Ensure that the refactored code maintains the correct flow of asynchronous operations and does not introduce new bugs or errors
  • Verify that the refactoring results in improved performance metrics, reducing execution time and resource consumption

Complexity: <High|Medium|Low> > A short comment to remind the reason for the rating

Uncertainty: <High|Medium|Low> > A short comment to remind the reason for the rating


Tasks:

  • Identify functions with return statements awaiting promises
  • Refactor return statements to directly return unresolved promises, removing the await keyword
  • Test the refactored code to ensure correct handling of asynchronous operations and absence of new issues
  • Measure and compare performance metrics before and after the refactoring to validate improvements

Done

  • Acceptance Criteria pass
  • Designs are up-to date
  • Unit Tests pass
  • Integration Tests pass
  • Code Style & Coverage meets standards
  • Changes made to config (default.json) are broadcast to team and follow-up tasks added to update helm charts and other deployment config.
  • TBD

Pull Requests:

  • TBD

Follow-up:

  • N/A

Dependencies:

  • N/A

Accountability:

  • Owner: TBC
  • QA/Review: TBC
@vijayg10 vijayg10 added story oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it core-dev-squad labels Nov 6, 2023
@JaneS321 JaneS321 added PI-23 and removed oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it labels Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants