-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mojaloop/#3488): enable batch processing #415
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments noted.
.../technical/central-ledger/assets/diagrams/sequence/seq-position-1.3.1-prepare-batch.plantuml
Outdated
Show resolved
Hide resolved
.../technical/central-ledger/assets/diagrams/sequence/seq-position-1.3.1-prepare-batch.plantuml
Outdated
Show resolved
Hide resolved
end note | ||
DB --> FACADE_POSITION_FULFIL: Return current state of transfer from DB | ||
deactivate DB | ||
FACADE_POSITION_FULFIL <-> FACADE_POSITION_FULFIL: Validate current state (transferState is 'RECEIVED-FULFIL')\n<color #FF0000><b>Error code:</b> 2001</color> against failing transfers\nBatch is not rejected as a whole |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is Payment Condition validated using the pre-image from the fulfill? Must not move a transfer to COMMITTED unless payment condition is fulfilled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @millerabel, great question.
It is done by the Central-Ledger Fulfil Handler, which will result in an event which will be consumed by the Central-Ledger Position Handler
(i.e. by either the existing Position processor, or the changes proposed here for batch processing) to either finalise the COMMIT
(i.e. commit funds to Payee) or ABORT
(i.e. release funds to Payer).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggested changes to address @millerabel's comment --> #415 (comment)
...chnical/central-ledger/assets/diagrams/sequence/seq-position-1.3.4.5-prepare-domain.plantuml
Outdated
Show resolved
Hide resolved
...chnical/central-ledger/assets/diagrams/sequence/seq-position-1.3.4.5-prepare-domain.plantuml
Outdated
Show resolved
Hide resolved
…ition-1.3.4.5-prepare-domain.plantuml Co-authored-by: Miguel de Barros <miguel@debarros.me>
…ition-1.3.4.5-prepare-domain.plantuml Co-authored-by: Miguel de Barros <miguel@debarros.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from me
…m/mojaloop/documentation into feat/3488-enable-batch-processing
No description provided.