Skip to content

Namespace the less mixin #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2017
Merged

Namespace the less mixin #27

merged 1 commit into from
Oct 25, 2017

Conversation

mitar
Copy link
Contributor

@mitar mitar commented Oct 25, 2017

By putting it inside #json-schema-view-js namespace one can import this file into another less file and mixin still works. Otherwise it complains about missing required named argument.

Diff is ugly, but it is just indentation.

BTW, what is the following selector:

.json-schema-view, json-schema-view {

json-schema-view is a custom HTML element? Where is that used?

@mohsen1
Copy link
Owner

mohsen1 commented Oct 25, 2017

You need to commit dist folder too

@mitar
Copy link
Contributor Author

mitar commented Oct 25, 2017

Oh, most repos want to commit only source, not dist. I will do it now.

@mitar
Copy link
Contributor Author

mitar commented Oct 25, 2017

Oh, there are no differences in output CSS, of course. :-) This is just to improve reuse in other less files.

@mohsen1
Copy link
Owner

mohsen1 commented Oct 25, 2017

dist folder is Bower legacy

I'll publish it with the other change you commented on

@mohsen1 mohsen1 merged commit 8e35522 into mohsen1:master Oct 25, 2017
@mitar mitar deleted the namespace-mixin branch October 25, 2017 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants