Improve build #44
Open
Improve build #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The CI complains about the permission error of the postinst script: I guess you need to chmod the permission of |
Contributor
Author
|
You're absolutely right, it happens sometimes. I'm going to fix this during the day ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I improved a little the way your app is build with meson.
I split the
meson.buildfiles within the different folders for more clarity. I also simplified thepost_install.pyscript and added the.editorconfigwith elementary recommended parameters.Finally I moved the gresources to a better location in
icons/symbolic.This PR is ready for review