Skip to content

Commit 39af8e0

Browse files
Merge pull request #137 from modulr-software/hotfix/fix-date-format
fixed date format
2 parents 2bf74ea + c5a60ec commit 39af8e0

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

src/source/services/analytics/core.clj

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
"returns the number of impressions, clicks and views per interval (:daily, :weekly, :monthly or :yearly) over the given time period,
4848
filtered by any other arguments accepted by metric-query.
4949
50-
Date parameters must be in the format YYYY-mm-dd."
50+
Date parameters must be in the format YYYY-MM-DD."
5151
[ds interval min-date max-date opts]
5252
(let [select (cond
5353
(= interval :daily) [[:date :timestamp] :day]
@@ -66,8 +66,8 @@
6666
[(hsql/filter :%count.* (hsql/where := :event "impression")) :impressions]
6767
[(hsql/filter :%count.* (hsql/where := :event "click")) :clicks]
6868
[(hsql/filter :%count.* (hsql/where := :event "view")) :views])
69-
:min-date (str min-date " 00:00:00")
70-
:max-date (str max-date " 23:59:59")
69+
:min-date (str min-date "T00:00:00Z")
70+
:max-date (str max-date "T23:59:59Z")
7171
:group-by (hsql/group-by column)
7272
:order-by (hsql/order-by column)}
7373
opts))))
@@ -306,7 +306,7 @@
306306
(dotimes [_ num-records]
307307
(seed-event! maximums)))
308308

309-
(time (metric-query ds {:min-date "2025-11-25 15:00:00"
309+
(time (metric-query ds {:min-date "2025-11-25T15:00:00Z"
310310
:feed-id "1"}))
311311

312312
(time (statistics-query ds {:ret :*}))
@@ -317,15 +317,15 @@
317317

318318
(time (hon/update! ds {:tname :events
319319
:where [:between :id 5000000 5500000]
320-
:data {:timestamp (str "2025-11-22" " 13:00:00")}
320+
:data {:timestamp (str "2025-11-22" "T13:00:00Z")}
321321
:ret :*}))
322322

323323
(time (hon/execute! ds (-> (hsql/select [[:date :timestamp] :day]
324324
[(hsql/filter :%count.* (hsql/where := :event "impression")) :impressions]
325325
[(hsql/filter :%count.* (hsql/where := :event "click")) :clicks]
326326
[(hsql/filter :%count.* (hsql/where := :event "view")) :views])
327327
(hsql/from :events)
328-
(hsql/where [:between :timestamp "2025-11-17 00:00:00" "2025-11-24 23:59:59"])
328+
(hsql/where [:between :timestamp "2025-11-17T00:00:00Z" "2025-11-24T23:59:59Z"])
329329
(hsql/group-by :day)
330330
(hsql/order-by :day)) {:ret :*}))
331331

@@ -336,7 +336,7 @@
336336
[(hsql/filter :%count.* (hsql/where := :event "click")) :clicks]
337337
[(hsql/filter :%count.* (hsql/where := :event "view")) :views])
338338
(hsql/from :events)
339-
(hsql/where [:between :timestamp "2025-11-01 00:00:00" "2025-11-30 23:59:00"])
339+
(hsql/where [:between :timestamp "2025-11-01T00:00:00Z" "2025-11-30T23:59:00Z"])
340340
(hsql/group-by :week)
341341
(hsql/order-by :week))
342342
{:ret :*}))
@@ -347,10 +347,10 @@
347347

348348
(time (weekly-growth-averages ds "2025-11-01" "2025-11-30" {:feed-id 4}))
349349

350-
(time (average-engagement ds "2025-11-24 00:00:00" "2025-11-24 23:59:59" {:feed-id 4}))
350+
(time (average-engagement ds "2025-11-24T00:00:00Z" "2025-11-24T23:59:59Z" {:feed-id 4}))
351351

352-
(time (click-through-rate ds {:min-date "2025-11-24 00:00:00"
353-
:max-date "2025-11-24 23:59:59"
352+
(time (click-through-rate ds {:min-date "2025-11-24T00:00:00Z"
353+
:max-date "2025-11-24T23:59:59Z"
354354
:feed-id 4}))
355355

356356
(time

0 commit comments

Comments
 (0)