Skip to content

Commit d5a9227

Browse files
chore: make router host e2e ci friendly
1 parent 20af9c5 commit d5a9227

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

apps/router-demo/router-host-2000/project.json

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,12 @@
4343
"browser": "electron",
4444
"exit": false,
4545
"watch": true
46+
},
47+
"ci": {
48+
"watch": false,
49+
"headed": false,
50+
"exit": true,
51+
"browser": "chrome"
4652
}
4753
}
4854
},
@@ -56,7 +62,7 @@
5662
"forwardAllArgs": false
5763
},
5864
{
59-
"command": "sleep 4 && nx run router-host-2000:e2e --watch",
65+
"command": "pnpm exec wait-on http://127.0.0.1:2000 && nx run router-host-2000:e2e --configuration=ci",
6066
"forwardAllArgs": true
6167
}
6268
]

tools/scripts/run-router-e2e.mjs

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -210,13 +210,6 @@ function getWaitFactory(scenario) {
210210
}
211211

212212
function getCiWaitMs(scenario) {
213-
const userOverride = Number.parseInt(
214-
process.env.ROUTER_E2E_CI_WAIT_MS ?? '',
215-
10,
216-
);
217-
if (!Number.isNaN(userOverride) && userOverride >= 0) {
218-
return userOverride;
219-
}
220213
if (typeof scenario.ciWaitMs === 'number' && scenario.ciWaitMs >= 0) {
221214
return scenario.ciWaitMs;
222215
}

0 commit comments

Comments
 (0)