Skip to content

Commit 210363d

Browse files
kyletsangkyletsang
authored
fix(nextjs-mf): fix react/jsx-runtime required version warning (#2503)
1 parent c01b5f1 commit 210363d

File tree

7 files changed

+157
-102
lines changed

7 files changed

+157
-102
lines changed

‎.changeset/plenty-shoes-grab.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@module-federation/nextjs-mf': patch
3+
---
4+
5+
Prevent react/jsx-runtime warnings from appearing

‎apps/website-new/docs/en/guide/framework/nextjs.mdx‎

Lines changed: 30 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -247,70 +247,80 @@ You do not need to share these packages, sharing next internals yourself will ca
247247
```ts
248248
export const DEFAULT_SHARE_SCOPE: SharedObject = {
249249
'next/dynamic': {
250-
eager: false,
251-
requiredVersion: false,
250+
requiredVersion: undefined,
252251
singleton: true,
253252
import: undefined,
254253
},
255254
'next/head': {
256-
eager: false,
257-
requiredVersion: false,
255+
requiredVersion: undefined,
258256
singleton: true,
259257
import: undefined,
260258
},
261259
'next/link': {
262-
eager: true,
263-
requiredVersion: false,
260+
requiredVersion: undefined,
264261
singleton: true,
265262
import: undefined,
266263
},
267264
'next/router': {
268265
requiredVersion: false,
269266
singleton: true,
270-
import: false,
271-
eager: false,
267+
import: undefined,
268+
},
269+
'next/image': {
270+
requiredVersion: undefined,
271+
singleton: true,
272+
import: undefined,
272273
},
273274
'next/script': {
274-
requiredVersion: false,
275+
requiredVersion: undefined,
275276
singleton: true,
276277
import: undefined,
277-
eager: false,
278278
},
279279
react: {
280280
singleton: true,
281281
requiredVersion: false,
282-
eager: false,
282+
import: false,
283+
},
284+
'react/': {
285+
singleton: true,
286+
requiredVersion: false,
287+
import: false,
288+
},
289+
'react-dom/': {
290+
singleton: true,
291+
requiredVersion: false,
283292
import: false,
284293
},
285294
'react-dom': {
286295
singleton: true,
287296
requiredVersion: false,
288-
eager: false,
289297
import: false,
290298
},
291299
'react/jsx-dev-runtime': {
292300
singleton: true,
293301
requiredVersion: false,
294-
import: undefined,
295-
eager: false,
296302
},
297303
'react/jsx-runtime': {
298304
singleton: true,
299305
requiredVersion: false,
300-
eager: false,
301-
import: false,
302306
},
303307
'styled-jsx': {
304-
requiredVersion: false,
305308
singleton: true,
306309
import: undefined,
307-
eager: false,
310+
version: require('styled-jsx/package.json').version,
311+
requiredVersion: '^' + require('styled-jsx/package.json').version,
308312
},
309313
'styled-jsx/style': {
310-
requiredVersion: false,
314+
singleton: true,
315+
import: false,
316+
version: require('styled-jsx/package.json').version,
317+
requiredVersion: '^' + require('styled-jsx/package.json').version,
318+
},
319+
'styled-jsx/css': {
311320
singleton: true,
312321
import: undefined,
313-
eager: false,
322+
version: require('styled-jsx/package.json').version,
323+
requiredVersion: '^' + require('styled-jsx/package.json').version,
314324
},
315325
};
316326
```

‎apps/website-new/docs/en/practice/frameworks/next/presets.mdx‎

Lines changed: 30 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -23,70 +23,80 @@ It's important to note that manually sharing these internals can lead to errors,
2323
```ts
2424
export const DEFAULT_SHARE_SCOPE: SharedObject = {
2525
'next/dynamic': {
26-
eager: false,
27-
requiredVersion: false,
26+
requiredVersion: undefined,
2827
singleton: true,
2928
import: undefined,
3029
},
3130
'next/head': {
32-
eager: false,
33-
requiredVersion: false,
31+
requiredVersion: undefined,
3432
singleton: true,
3533
import: undefined,
3634
},
3735
'next/link': {
38-
eager: true,
39-
requiredVersion: false,
36+
requiredVersion: undefined,
4037
singleton: true,
4138
import: undefined,
4239
},
4340
'next/router': {
4441
requiredVersion: false,
4542
singleton: true,
46-
import: false,
47-
eager: false,
43+
import: undefined,
44+
},
45+
'next/image': {
46+
requiredVersion: undefined,
47+
singleton: true,
48+
import: undefined,
4849
},
4950
'next/script': {
50-
requiredVersion: false,
51+
requiredVersion: undefined,
5152
singleton: true,
5253
import: undefined,
53-
eager: false,
5454
},
5555
react: {
5656
singleton: true,
5757
requiredVersion: false,
58-
eager: false,
58+
import: false,
59+
},
60+
'react/': {
61+
singleton: true,
62+
requiredVersion: false,
63+
import: false,
64+
},
65+
'react-dom/': {
66+
singleton: true,
67+
requiredVersion: false,
5968
import: false,
6069
},
6170
'react-dom': {
6271
singleton: true,
6372
requiredVersion: false,
64-
eager: false,
6573
import: false,
6674
},
6775
'react/jsx-dev-runtime': {
6876
singleton: true,
6977
requiredVersion: false,
70-
import: undefined,
71-
eager: false,
7278
},
7379
'react/jsx-runtime': {
7480
singleton: true,
7581
requiredVersion: false,
76-
eager: false,
77-
import: false,
7882
},
7983
'styled-jsx': {
80-
requiredVersion: false,
8184
singleton: true,
8285
import: undefined,
83-
eager: false,
86+
version: require('styled-jsx/package.json').version,
87+
requiredVersion: '^' + require('styled-jsx/package.json').version,
8488
},
8589
'styled-jsx/style': {
86-
requiredVersion: false,
90+
singleton: true,
91+
import: false,
92+
version: require('styled-jsx/package.json').version,
93+
requiredVersion: '^' + require('styled-jsx/package.json').version,
94+
},
95+
'styled-jsx/css': {
8796
singleton: true,
8897
import: undefined,
89-
eager: false,
98+
version: require('styled-jsx/package.json').version,
99+
requiredVersion: '^' + require('styled-jsx/package.json').version,
90100
},
91101
};
92102
```

‎apps/website-new/docs/zh/guide/framework/nextjs.mdx‎

Lines changed: 30 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -23,70 +23,80 @@
2323
```ts
2424
export const DEFAULT_SHARE_SCOPE: SharedObject = {
2525
'next/dynamic': {
26-
eager: false,
27-
requiredVersion: false,
26+
requiredVersion: undefined,
2827
singleton: true,
2928
import: undefined,
3029
},
3130
'next/head': {
32-
eager: false,
33-
requiredVersion: false,
31+
requiredVersion: undefined,
3432
singleton: true,
3533
import: undefined,
3634
},
3735
'next/link': {
38-
eager: true,
39-
requiredVersion: false,
36+
requiredVersion: undefined,
4037
singleton: true,
4138
import: undefined,
4239
},
4340
'next/router': {
4441
requiredVersion: false,
4542
singleton: true,
46-
import: false,
47-
eager: false,
43+
import: undefined,
44+
},
45+
'next/image': {
46+
requiredVersion: undefined,
47+
singleton: true,
48+
import: undefined,
4849
},
4950
'next/script': {
50-
requiredVersion: false,
51+
requiredVersion: undefined,
5152
singleton: true,
5253
import: undefined,
53-
eager: false,
5454
},
5555
react: {
5656
singleton: true,
5757
requiredVersion: false,
58-
eager: false,
58+
import: false,
59+
},
60+
'react/': {
61+
singleton: true,
62+
requiredVersion: false,
63+
import: false,
64+
},
65+
'react-dom/': {
66+
singleton: true,
67+
requiredVersion: false,
5968
import: false,
6069
},
6170
'react-dom': {
6271
singleton: true,
6372
requiredVersion: false,
64-
eager: false,
6573
import: false,
6674
},
6775
'react/jsx-dev-runtime': {
6876
singleton: true,
6977
requiredVersion: false,
70-
import: undefined,
71-
eager: false,
7278
},
7379
'react/jsx-runtime': {
7480
singleton: true,
7581
requiredVersion: false,
76-
eager: false,
77-
import: false,
7882
},
7983
'styled-jsx': {
80-
requiredVersion: false,
8184
singleton: true,
8285
import: undefined,
83-
eager: false,
86+
version: require('styled-jsx/package.json').version,
87+
requiredVersion: '^' + require('styled-jsx/package.json').version,
8488
},
8589
'styled-jsx/style': {
86-
requiredVersion: false,
90+
singleton: true,
91+
import: false,
92+
version: require('styled-jsx/package.json').version,
93+
requiredVersion: '^' + require('styled-jsx/package.json').version,
94+
},
95+
'styled-jsx/css': {
8796
singleton: true,
8897
import: undefined,
89-
eager: false,
98+
version: require('styled-jsx/package.json').version,
99+
requiredVersion: '^' + require('styled-jsx/package.json').version,
90100
},
91101
};
92102
```

0 commit comments

Comments
 (0)