Fix bug with 'git remote set-branches origin main' #86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was hitting a bug where every PR would use the same name
jansel/stack/1
, for example:jansel/stack/2
would never get used, and stack-pr would clobber itself and be very broken.The issue was my git was configured to only fetch
main
rather than all branches. You can repro this with:(and also delete all your local cached remote refs).
One fix would be:
however, this modifies my global git config -- and users won't know they need to run that command.
This PR fixes the issue by forcing all branches to be fetched.
One potential improvement would be a more narrow fetch like:
which will make stack-pr faster in large multi-user projects, though I will leave that to others to implement since I don't have a great testing setup.