Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: modular/stack-pr
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.1.1
Choose a base ref
...
head repository: modular/stack-pr
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.1.2
Choose a head ref
  • 15 commits
  • 7 files changed
  • 5 contributors

Commits on Aug 24, 2024

  1. Emit terminal hyperlinks (#19)

    Implements enough of the [terminal hyperlink specification][1] to allow
    us to include links to PRs, where they exist, in the terminal output.
    
    This specification is implemented by several terminals, including:
    - kitty
    - wezterm
    - iTerm2
    - Alacritty
    - Windows Terminal
    - Konsole
    - xterm.js (VS Code's backing terminal implementation)
    
    See [this tracking repository][2] for a full listing.
    
    The ECMA-48 specification requires that terminals that do not understand
    the OSC-8 command code silently ignore it; in compliant terminals that
    do not implement the hyperlink specification, users will simply observe
    no changes to the output of `stack-pr`. For cases where outputting these
    escape codes is still undesirable I have added a `--no-hyperlinks` flag.
    
    [1]: https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda
    [2]: https://github.com/Alhadis/OSC8-Adoption/
    AmaranthineCodices authored Aug 24, 2024
    Configuration menu
    Copy the full SHA
    ea8bc06 View commit details
    Browse the repository at this point in the history
  2. Add a None check for exc.stdout. (#21)

    Fixes #15.
    ZolotukhinM authored Aug 24, 2024
    Configuration menu
    Copy the full SHA
    85e6cd4 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Check that the bottom PR is mergeable (#20)

    GitHub lets you check if a PR is actually mergeable via the `gh` CLI by
    retrieving the `mergeStateStatus` field. This field has a bunch of
    values (see the [API documentation][1] linked below), but the one we care
    about is `CLEAN`, indicating that the PR has no merge conflicts and has
    passed PR checks.
    
    I'd like to eventually add this information to `stack-pr view`, but it will
    require some extra piping, and will slow down the command due to the
    extra network request.
    
    1: https://docs.github.com/en/graphql/reference/enums#mergestatestatus
    AmaranthineCodices authored Aug 26, 2024
    Configuration menu
    Copy the full SHA
    804f0bf View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2024

  1. Fix delete_remote_branches (#27)

    delete_remote_branches formatted remote
    branch refs with an extra single quote
    around each branch. These would never
    match the branch strings stored in
    stack entries, so remote branches would
    never get deleted. This commit removes
    the extra single quotes.
    cleithner-comcast authored Oct 5, 2024
    Configuration menu
    Copy the full SHA
    3161fcb View commit details
    Browse the repository at this point in the history
  2. Suppress subcommand output by default (#26)

    For large or busy repositories, stack-pr commands can generate hundreds
    of lines of output from Git subcommands being executed. Most of the time
    these don't matter; the user doesn't care about them. This PR suppresses
    them by default by redirecting stdout and stderr to
    `subprocess.DEVNULL`. If this output is desired in a specific case, the
    command-line flag `--verbose` (`-V`) can be used to avoid this
    redirection.
    AmaranthineCodices authored Oct 5, 2024
    Configuration menu
    Copy the full SHA
    a2af242 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2024

  1. Configuration menu
    Copy the full SHA
    f6aa5ae View commit details
    Browse the repository at this point in the history
  2. Add config files feature. (#32)

    The allows to have a local config to customize defaults for CL options.
    
    Closes #22.
    ZolotukhinM authored Oct 6, 2024
    Configuration menu
    Copy the full SHA
    adacd0a View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Configuration menu
    Copy the full SHA
    a5e0725 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Configuration menu
    Copy the full SHA
    79d6dde View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5220b76 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2024

  1. Show executed commands when --verbose is on. (#38)

    stack-info: PR: #38, branch: ZolotukhinM/stack/3
    ZolotukhinM authored Oct 12, 2024
    Configuration menu
    Copy the full SHA
    331cb54 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a1256e7 View commit details
    Browse the repository at this point in the history
  3. Don't attempt to delete remote branch after a PR has landed. (#42)

    GitHub deletes the remote branch automatically when the PR is merged, so
    we don't to explicitly do that. Trying to delete it currently results in
    an error like this:
    ```
    error: unable to delete 'ZolotukhinM/stack/1': remote ref does not exist
    error: failed to push some refs to '...'
    ```
    The code for deleting the branch has been sitting there for a long time,
    but until a fix in #27 it used incorrect branch names.
    ZolotukhinM authored Oct 12, 2024
    Configuration menu
    Copy the full SHA
    7cbd8ab View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Configuration menu
    Copy the full SHA
    a3b909e View commit details
    Browse the repository at this point in the history
  2. Formatting

    ZolotukhinM committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    940741b View commit details
    Browse the repository at this point in the history
Loading