Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Superfluous require guard on WithdrawOwnerEth() #84

Open
maurelian opened this issue Feb 25, 2018 · 0 comments
Open

Superfluous require guard on WithdrawOwnerEth() #84

maurelian opened this issue Feb 25, 2018 · 0 comments

Comments

@maurelian
Copy link

What is it?

CrowdSaleLib makes a check on the token balance, to determine eligibility to withdraw Ether.

https://github.com/Modular-Network/ethereum-libraries/blob/audits/CrowdsaleLib/IICOLib/truffle/contracts/CrowdsaleLib.sol#L204

Problem

I can't see a reason that contract's token balance would need to be checked in order to allow a withdrawal, and I can think of some problem's it might cause.

@maurelian maurelian changed the title unrelated require guard on WithdrawOwnerEth() Superfluous require guard on WithdrawOwnerEth() Feb 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant