Skip to content
This repository has been archived by the owner on Nov 14, 2024. It is now read-only.

Add archive class to gcs #432

Conversation

modular-magician
Copy link
Owner

Small changes that add "ARCHIVE" class to GCS documentation google_storage_bucket and google_storage_bucket_object.
I also added a lifecycle rule in one of the tests to use that new class.
Then I updated the api.yaml to handle the archive class.

Note : Acceptance tests did not run because the changes are quite small. I decided to not run the full tests suite.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

storage: added `ARCHIVE` as an accepted class for `google_storage_bucket` and `google_storage_bucket_object`

Derived from GoogleCloudPlatform/magic-modules#3867

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit b8772a7 into master Aug 14, 2020
slevenick added a commit that referenced this pull request Oct 27, 2020
* fix typo (#3369) (#413)

Signed-off-by: Modular Magician <magic-modules@google.com>

* Fix check for serial port disabled (#3695) (#415)

* Fix check for serial port disabled

* fix check for block-project-ssh-keys

Signed-off-by: Modular Magician <magic-modules@google.com>

* Add mode enum and scale down controls for Compute AutoScaler (#3693) (#416)

* Add mode enum and scale down controls for Compute AutoScaler

* Add mode enum for Compute AutoScaler in the correct API block

* Add defaults for mode and default_from_api for scale down controls

* Add tests for scale_down_controls and set at_least_one_of for it

Signed-off-by: Modular Magician <magic-modules@google.com>

* added support for shielded nodes in container (#3639) (#417)

Signed-off-by: Modular Magician <magic-modules@google.com>

* fix memcache_parameters (#3733) (#418)

* change memcacheParameters to parameters, add parameters to basic test

* make switching memcacheParameters to parameters not a breaking-change

Signed-off-by: Modular Magician <magic-modules@google.com>

* add tiers and nfs_export_options (#3766) (#419)

* add tiers and nfs_export_options

* update docs, make full test beta

Signed-off-by: Modular Magician <magic-modules@google.com>

* Add skip enum value generation (#3767) (#420)

* Add skip enum value generation

* Fix default

* Fix reader

* Fix line spacing on enum values

Signed-off-by: Modular Magician <magic-modules@google.com>

* Backend service support for internet NEG backend (#3782) (#421)

* Add ability to set global network endpoint group as backend for backend service. Make health_checks optional

* PR fixes

* Add encoder to remove max_utilization when neg backend

* Check for global NEG in group to remove max_utilization

* Add another nil check

* Spacing

* Docs fix

Signed-off-by: Modular Magician <magic-modules@google.com>

* add firewall logging controls (#3780) (#422)

* add firewall logging controls

* make backward compatible

* check enable_logging in expand

* update docs

* update expand logic to fix failing test

Signed-off-by: Modular Magician <magic-modules@google.com>

* Fix colon in doc notes (#3796) (#423)

Signed-off-by: Modular Magician <magic-modules@google.com>

* Add persistence_iam_identity to Redis Instance (#3805) (#424)

Signed-off-by: Modular Magician <magic-modules@google.com>

* Org Security Policies (Hierarchical Firewalls) (#3626) (#425)

Co-authored-by: Dana Hoffman <danahoffman@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>

Co-authored-by: Dana Hoffman <danahoffman@google.com>

* Adding Missing Cloud Build Attributes (#3627) (#426)

Signed-off-by: Modular Magician <magic-modules@google.com>

* Add additional fields to Memcached Instance (#3821) (#427)

Signed-off-by: Modular Magician <magic-modules@google.com>

* Convert inboundServices to an enum. (#3820) (#428)

Signed-off-by: Modular Magician <magic-modules@google.com>

* add source_image and source_snapshot to google_compute_image (#3799) (#429)

* add source_image to google_compute_image

* add source_snapshot to google_compute_image

* PR comment changes

Signed-off-by: Modular Magician <magic-modules@google.com>

* Collection fixes for release (#3831) (#430)

Signed-off-by: Modular Magician <magic-modules@google.com>

* Add new field filter to pubsub. (#3759) (#431)

* Add new field filter to pubsub.

Fixes: hashicorp/terraform-provider-google#6727

* Fixed filter name, it was improperly set.

* add filter key to pubsub subscription unit test

* spaces not tabs!

* hardcode filter value in test

* revert remove escaped quotes

Co-authored-by: Tim O'Connell <hi@timoconnell.co.uk>
Signed-off-by: Modular Magician <magic-modules@google.com>

Co-authored-by: Tim O'Connell <hi@timoconnell.co.uk>

* Add archive class to gcs (#3867) (#432)

Signed-off-by: Modular Magician <magic-modules@google.com>

* Add support for gRPC healthchecks (#3825) (#433)

Signed-off-by: Modular Magician <magic-modules@google.com>

* Add enableMessageOrdering to Pub/Sub Subscription (#3872) (#434)

Add enableMessageOrdering to Pub/Sub Subscription

Signed-off-by: Modular Magician <magic-modules@google.com>

* Specify possible values for arg only once (#3874) (#435)

Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
Signed-off-by: Modular Magician <magic-modules@google.com>

* use {product}.googleapis.com endpoints (#3755) (#436)

* use {product}.googleapis.com endpoints

* use actual correct urls

* fix zone data source test

* fix network peering tests

* possibly fix deleting default network

Signed-off-by: Modular Magician <magic-modules@google.com>

* Add vpcAccessConnector property on google_app_engine_standard_app_version terraform resource (#3789) (#437)

* add vpc access connector property in standard app version resource

* add Gemfile.lock and .ruby-version

* modify .ruby-version

* Update Gemfile.lock

* Update Gemfile.lock

* Update Gemfile.lock

* add test for vpcAccessConnector field

* change casing of test field

* add comma

* format app engine connector test

* make vpc_access_connector an object

* add vpc access connector resource to test

* pass connector id output property to app engine resource instead of hardcoding connector id

Signed-off-by: Modular Magician <magic-modules@google.com>

* retrypolicy attribute added (#3843) (#438)

* retrypolicy attribute added

* test case updated

Signed-off-by: Modular Magician <magic-modules@google.com>

* add discovery endpoint (#3891) (#439)

Signed-off-by: Modular Magician <magic-modules@google.com>

* Advanced logging config options in google_compute_subnetwork (#3603) (#440)

Co-authored-by: Dana Hoffman <danahoffman@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>

Co-authored-by: Dana Hoffman <danahoffman@google.com>

* Add Erase Windows VSS support to compute disk (#3898) (#441)

Co-authored-by: Cameron Thornton <camthornton@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>

Co-authored-by: Cameron Thornton <camthornton@google.com>

* Add Snapshot location to compute snapshot (#3896) (#442)

* added storage locations

* add storage locations to field

* tweak cmek logic

* fix the decoder logic and cleanup whitespaces

* remove duplicate entry

Signed-off-by: Modular Magician <magic-modules@google.com>

* Added missing 'all' option for protocol firewall rule (#3962) (#443)

Signed-off-by: Modular Magician <magic-modules@google.com>

* Revert `eraseWindowsVssSignature` field and test (#3959) (#444)

Signed-off-by: Modular Magician <magic-modules@google.com>

* Added support GRPC for google_compute_(region)_backend_service.protocol (#3973) (#445)

Co-authored-by: Edward Sun <sunedward@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>

Co-authored-by: Edward Sun <sunedward@google.com>

* Added properties of options & artifacts on google_cloudbuild_trigger (#3944) (#446)

* added options & artifacts to cloudbuild trigger

* updated with minor changes and added more options in test

* a test adding update behavior for multiple optional fields

Co-authored-by: Edward Sun <sunedward@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>

Co-authored-by: Edward Sun <sunedward@google.com>

* products/container: Add datapath provider field (#3956) (#447)

Signed-off-by: Modular Magician <magic-modules@google.com>

* Add SEV_CAPABLE option to google_compute_image (#3994) (#448)

Signed-off-by: Modular Magician <magic-modules@google.com>

* Add network peerings for inspec (#4002) (#449)

Signed-off-by: Modular Magician <magic-modules@google.com>

* Update docs for pubsub targets in cloud scheduler (#4008) (#450)

Signed-off-by: Modular Magician <magic-modules@google.com>

Co-authored-by: The Magician <magic-modules@google.com>
Co-authored-by: Dana Hoffman <danahoffman@google.com>
Co-authored-by: Tim O'Connell <hi@timoconnell.co.uk>
Co-authored-by: Cameron Thornton <camthornton@google.com>
Co-authored-by: Edward Sun <sunedward@google.com>
Co-authored-by: Stuart Paterson <spaterson@chef.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant