Add an in #3300
Closed
Add an in #3300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Already being worked on / reported. |
| @@ -448,7 +448,7 @@ async def send_scheduled_close_message(self, ctx, after, silent=False): | |||
|
|
|||
| embed = discord.Embed( | |||
| title="Scheduled close", | |||
| description=f"This thread will close {silent}{human_delta}.", | |||
| description=f"This thread will close in {silent}{human_delta}.", | |||
There was a problem hiding this comment.
I think it should be put between {silent} and {human_delta}. Otherwise if it's silent, the output would be:
This thread will close in silently 2 hours.
Suggested change
| description=f"This thread will close in {silent}{human_delta}.", | |
| description=f"This thread will close {silent}in {human_delta}.", |
Updated:
We already have a merge commit that fixed this.
|
Duplicate of #3233, this is already fixed in develop branch. PRs should also target the develop branch, not master. |
|
Already merged into the dev branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be "This thread will close IN " rather than "This thread will close
This is a minor issue that has been missed for two years according to Lorenzo. I told them that I'd throw in a quick pull request for it.