-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT-#1222: Implement DataFrame.asof() without Pandas fallback #1989
Conversation
Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor points left.
You many need to update black
to pass CI.
Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
Codecov Report
@@ Coverage Diff @@
## master #1989 +/- ##
==========================================
+ Coverage 81.80% 81.83% +0.02%
==========================================
Files 79 79
Lines 9389 9418 +29
==========================================
+ Hits 7681 7707 +26
- Misses 1708 1711 +3
Continue to review full report at Codecov.
|
Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
Merged forward, and updated docs; anything else? |
Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
This now covers #1239 as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @itamarst, looks great
…llback (modin-project#1989) Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
What do these changes do?
flake8 modin
black --check modin
git commit -s