Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect condition in test_io masks Modin bug #6467

Open
vnlitvinov opened this issue Aug 7, 2023 · 1 comment
Open

Incorrect condition in test_io masks Modin bug #6467

vnlitvinov opened this issue Aug 7, 2023 · 1 comment
Assignees
Labels
bug 🦗 Something isn't working P1 Important tasks that we should complete soon pandas concordance 🐼 Functionality that does not match pandas

Comments

@vnlitvinov
Copy link
Collaborator

vnlitvinov commented Aug 7, 2023

In debugging the CI failure, I think I found another issue -- this check is supposed to be about Pandas v2, according to #6072, but it is actually checking the Modin version.

if (
version.parse(pa.__version__) >= version.parse("12.0.0")
and version.parse(pd.__version__) < version.parse("2.0.0")
and engine == "pyarrow"
):
pytest.xfail("incompatible versions; see #6072")

I believe this is covering up a Modin bug having to do with period range indices.

Originally posted by @zmbc in #6442 (comment)

I had verified that, when condition is rectified, the issue manifests on Ray engine (but does not manifest on Python engine!)

@vnlitvinov vnlitvinov added bug 🦗 Something isn't working pandas concordance 🐼 Functionality that does not match pandas P1 Important tasks that we should complete soon labels Aug 7, 2023
@vnlitvinov
Copy link
Collaborator Author

cc @anmyachev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🦗 Something isn't working P1 Important tasks that we should complete soon pandas concordance 🐼 Functionality that does not match pandas
Projects
None yet
Development

No branches or pull requests

2 participants